net: pcs: xpcs: rearrange xpcs_link_up_1000basex()

Rearrange xpcs_link_up_1000basex() to make it more obvious what will
happen in the following commit.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tested-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
index 183df8f8c50fda2ef4e8379c6bd3ac555075e846..3222b8851bff44eda524c7965391b74743d94cde 100644 (file)
--- a/drivers/net/pcs/pcs-xpcs.c
+++ b/drivers/net/pcs/pcs-xpcs.c
@@ -1133,12 +1133,13 @@ static void xpcs_link_up_1000basex(struct dw_xpcs *xpcs, unsigned int neg_mode,
                return;
        }
 
+       if (duplex != DUPLEX_FULL)
+               dev_err(&xpcs->mdiodev->dev, "%s: half duplex not supported\n",
+                       __func__);
+
        val = BMCR_SPEED1000;
        if (duplex == DUPLEX_FULL)
                val |= BMCR_FULLDPLX;
-       else
-               dev_err(&xpcs->mdiodev->dev, "%s: half duplex not supported\n",
-                       __func__);
 
        ret = xpcs_write(xpcs, MDIO_MMD_VEND2, MII_BMCR, val);
        if (ret)