]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sched_ext: Swap argument positions in kcalloc() call to avoid compiler warning
authorTejun Heo <tj@kernel.org>
Mon, 1 Jul 2024 18:30:02 +0000 (08:30 -1000)
committerTejun Heo <tj@kernel.org>
Mon, 1 Jul 2024 18:30:02 +0000 (08:30 -1000)
alloc_exit_info() calls kcalloc() but puts in the size of the element as the
first argument which triggers the following gcc warning:

  kernel/sched/ext.c:3815:32: warning: ‘kmalloc_array_noprof’ sizes
  specified with ‘sizeof’ in the earlier argument and not in the later
  argument [-Wcalloc-transposed-args]

Fix it by swapping the positions of the first two arguments. No functional
changes.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Vishal Chourasia <vishalc@linux.ibm.com>
Link: http://lkml.kernel.org/r/ZoG6zreEtQhAUr_2@linux.ibm.com
kernel/sched/ext.c

index f6e25545bfc0ea4dcd2dd566f1ee52dc20449589..ae9ec8f542f28d924f76da690c70c1e6bdeaab8d 100644 (file)
@@ -3812,7 +3812,7 @@ static struct scx_exit_info *alloc_exit_info(size_t exit_dump_len)
        if (!ei)
                return NULL;
 
-       ei->bt = kcalloc(sizeof(ei->bt[0]), SCX_EXIT_BT_LEN, GFP_KERNEL);
+       ei->bt = kcalloc(SCX_EXIT_BT_LEN, sizeof(ei->bt[0]), GFP_KERNEL);
        ei->msg = kzalloc(SCX_EXIT_MSG_LEN, GFP_KERNEL);
        ei->dump = kzalloc(exit_dump_len, GFP_KERNEL);