]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Remove a special case
authorVolker Lendecke <vl@samba.org>
Wed, 27 Nov 2024 15:40:03 +0000 (16:40 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 3 Dec 2024 08:01:30 +0000 (08:01 +0000)
dom_sid_parse_endp does accept the lowercase "s" in "s-1-1-0".

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
libcli/security/sddl.c

index c2a6ca26fc31b0498829b27e11f4552ee39f6ca8..0796a52878f315cf57ce1256043d2e18c976ab1f 100644 (file)
@@ -230,13 +230,6 @@ static struct dom_sid *sddl_transition_decode_sid(TALLOC_CTX *mem_ctx, const cha
                if (sid_str == NULL) {
                        return NULL;
                }
-               if (sid_str[0] == 's') {
-                       /*
-                        * In SDDL, but not in the dom_sid parsers, a
-                        * lowercase "s-1-1-0" is accepted.
-                        */
-                       sid_str[0] = 'S';
-               }
                sid = talloc(mem_ctx, struct dom_sid);
                if (sid == NULL) {
                        TALLOC_FREE(sid_str);