NFSD: always drop directory lock in nfsd_unlink()

Some error paths in nfsd_unlink() allow it to exit without unlocking the
directory.  This is not a problem in practice as the directory will be
locked with an fh_put(), but it is untidy and potentially confusing.

This allows us to remove all the fh_unlock() calls that are immediately
after nfsd_unlink() calls.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index 1fb75a68b8e54777e8de6c91b83a2bd9c6219ba9..3de9b008626cee551daee7616bea5afb5750f824 100644 (file)
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -490,7 +490,6 @@ nfsd3_proc_remove(struct svc_rqst *rqstp)
        fh_copy(&resp->fh, &argp->fh);
        resp->status = nfsd_unlink(rqstp, &resp->fh, -S_IFDIR,
                                   argp->name, argp->len);
-       fh_unlock(&resp->fh);
        return rpc_success;
 }
 
@@ -511,7 +510,6 @@ nfsd3_proc_rmdir(struct svc_rqst *rqstp)
        fh_copy(&resp->fh, &argp->fh);
        resp->status = nfsd_unlink(rqstp, &resp->fh, S_IFDIR,
                                   argp->name, argp->len);
-       fh_unlock(&resp->fh);
        return rpc_success;
 }
 

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index d585c01d8da6109bbee3eda8d74c950cb8f65823..8d01cb6d04e3cb350b2344a939a11c12fc7dc527 100644 (file)
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1002,10 +1002,8 @@ nfsd4_remove(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
                return nfserr_grace;
        status = nfsd_unlink(rqstp, &cstate->current_fh, 0,
                             remove->rm_name, remove->rm_namelen);
-       if (!status) {
-               fh_unlock(&cstate->current_fh);
+       if (!status)
                set_change_info(&remove->rm_cinfo, &cstate->current_fh);
-       }
        return status;
 }
 

diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index e726495f20759eeeb0118e6d034180bb3869fa4a..00b0b80c0c44746a1fdd6b688f4633dc0a029b3e 100644 (file)
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1753,12 +1753,12 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type,
        rdentry = lookup_one_len(fname, dentry, flen);
        host_err = PTR_ERR(rdentry);
        if (IS_ERR(rdentry))
-               goto out_drop_write;
+               goto out_unlock;
 
        if (d_really_is_negative(rdentry)) {
                dput(rdentry);
                host_err = -ENOENT;
-               goto out_drop_write;
+               goto out_unlock;
        }
        rinode = d_inode(rdentry);
        ihold(rinode);
@@ -1796,6 +1796,9 @@ out_nfserr:
        }
 out:
        return err;
+out_unlock:
+       fh_unlock(fhp);
+       goto out_drop_write;
 }
 
 /*