domsid: be less alarmed by non-SID

This has been causing log noise when something is trying to parse an
identifier using a sequence of parsers, to see if it is a SID, a DN,
an account name, etc.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index c898d87f64a669cf9a6e87d3768dc22cf773a1df..2cb755dcd423eedf83ea51574d53271e4bf44c80 100644 (file)
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -163,7 +163,8 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
        *sidout = (struct dom_sid) {};
 
        if ((sidstr[0] != 'S' && sidstr[0] != 's') || sidstr[1] != '-') {
-               goto format_error;
+               DBG_INFO("'%s' is not a SID\n", sidstr);
+               return false;
        }
 
        /* Get the revision number. */