tools/insmod: remove unused -p -s shortopts

These have been around since the import to git, doing nothing. There are
no users that I can see, the manual page does not list them and the
shell completions (fish and bash lack any for insmod, zsh has one) don't
suggest it either.

Remove them.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/138
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>

diff --git a/tools/insmod.c b/tools/insmod.c
index 94452ffa5eb19b218bdd7fd2d6a28eb5887193f9..825cd7f2f2661945203f1a98967a9610a80c11f3 100644 (file)
--- a/tools/insmod.c
+++ b/tools/insmod.c
@@ -15,7 +15,7 @@
 
 #include "kmod.h"
 
-static const char cmdopts_s[] = "psfVh";
+static const char cmdopts_s[] = "fVh";
 static const struct option cmdopts[] = {
        {"version", no_argument, 0, 'V'},
        {"help", no_argument, 0, 'h'},
@@ -65,10 +65,6 @@ static int do_insmod(int argc, char *argv[])
                if (c == -1)
                        break;
                switch (c) {
-               case 'p':
-               case 's':
-                       /* ignored, for compatibility only */
-                       break;
                case 'f':
                        flags |= KMOD_PROBE_FORCE_MODVERSION;
                        flags |= KMOD_PROBE_FORCE_VERMAGIC;