rtc: st-lpc: Use IRQF_NO_AUTOEN flag in request_irq()

If request_irq() fails in st_rtc_probe(), there is no need to enable
the irq, and if it succeeds, disable_irq() after request_irq() still has
a time gap in which interrupts can come.

request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when
request IRQ.

Fixes: b5b2bdfc2893 ("rtc: st: Add new driver for ST's LPC RTC")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20240912033727.3013951-1-ruanjinjie@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c
index d492a2d26600c1bd64f23738b04ad7cad24409e1..c6d4522411b312f94de2701ff4ff491e5323aa96 100644 (file)
--- a/drivers/rtc/rtc-st-lpc.c
+++ b/drivers/rtc/rtc-st-lpc.c
@@ -218,15 +218,14 @@ static int st_rtc_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       ret = devm_request_irq(&pdev->dev, rtc->irq, st_rtc_handler, 0,
-                              pdev->name, rtc);
+       ret = devm_request_irq(&pdev->dev, rtc->irq, st_rtc_handler,
+                              IRQF_NO_AUTOEN, pdev->name, rtc);
        if (ret) {
                dev_err(&pdev->dev, "Failed to request irq %i\n", rtc->irq);
                return ret;
        }
 
        enable_irq_wake(rtc->irq);
-       disable_irq(rtc->irq);
 
        rtc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
        if (IS_ERR(rtc->clk))