]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd: Show an info message about optional firmware missing
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 5 Dec 2024 16:51:27 +0000 (10:51 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 10 Dec 2024 15:26:52 +0000 (10:26 -0500)
With the warning from the core about missing firmware gone,
users still may be notified of missing optional firmware by
a more friendly message to clarify it's optional.

Suggested-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c

index ffbb3377e0f67325140a46939229d741a3012a5e..cf700824b960b7ace8aa43f677ee64f3490ecd23 100644 (file)
@@ -1459,8 +1459,11 @@ int amdgpu_ucode_request(struct amdgpu_device *adev, const struct firmware **fw,
 
        if (required == AMDGPU_UCODE_REQUIRED)
                r = request_firmware(fw, fname, adev->dev);
-       else
+       else {
                r = firmware_request_nowarn(fw, fname, adev->dev);
+               if (r)
+                       drm_info(&adev->ddev, "Optional firmware \"%s\" was not found\n", fname);
+       }
        if (r)
                return -ENODEV;