Improved detection of cells that extend into the reserved space at the end

of the page while adjusting overflow page pointers during autovacuum.

FossilOrigin-Name: 8097712c9c1f4ea16bc5dd462da248ef98896061

diff --git a/manifest b/manifest
index ecc1cabab4df44c5593aa2ea6f261b3ac319dd3f..64318a45bb3f7ed4bddecb82b1da7d3ab6e9145d 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Remove\sinvalid\stest\scase\sfrom\scursorhints2.test
-D 2017-01-12T11:52:47.951
+C Improved\sdetection\sof\scells\sthat\sextend\sinto\sthe\sreserved\sspace\sat\sthe\send\nof\sthe\spage\swhile\sadjusting\soverflow\spage\spointers\sduring\sautovacuum.
+D 2017-01-12T15:11:03.724
 F Makefile.in 41bd4cad981487345c4a84081074bcdb876e4b2e
 F Makefile.linux-gcc 7bc79876b875010e8c8f9502eb935ca92aa3c434
 F Makefile.msc b8ca53350ae545e3562403d5da2a69cec79308da
@@ -331,7 +331,7 @@ F src/auth.c 930b376a9c56998557367e6f7f8aaeac82a2a792
 F src/backup.c faf17e60b43233c214aae6a8179d24503a61e83b
 F src/bitvec.c 17ea48eff8ba979f1f5b04cc484c7bb2be632f33
 F src/btmutex.c 0e9ce2d56159b89b9bc8e197e023ee11e39ff8ca
-F src/btree.c 44e9612965f63bef288673b81faa43e765bcac5f
+F src/btree.c 90f8b15ec9baf65d5bfff65bdaee773b928836c1
 F src/btree.h e6d352808956ec163a17f832193a3e198b3fb0ac
 F src/btreeInt.h 10c4b77c2fb399580babbcc7cf652ac10dba796e
 F src/build.c 9e799f1edd910dfa8a0bc29bd390d35d310596af
@@ -1544,7 +1544,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P c07aef6f909fe35de110f0b180dbf5aa4c226af3
-R c1c1751767bcc81e2bffd9195a0f35dd
+P 163cc1b2f7100827d5803b81dcd97a1417744f66
+R d095162836679cc779e9b3972f22e3ea
 U drh
-Z 744c5ff27f4cf888c7a2ae696c740d23
+Z e05f25d6fff0c473a188620363f2fa54

diff --git a/manifest.uuid b/manifest.uuid
index daa470f6cadb5f24b536bb8e44f71f20532522ec..ae5d12009d4b3cb251f76bd4cda90cf45cb72fb2 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-163cc1b2f7100827d5803b81dcd97a1417744f66
\ No newline at end of file
+8097712c9c1f4ea16bc5dd462da248ef98896061
\ No newline at end of file

diff --git a/src/btree.c b/src/btree.c
index 60f886bf5a6e744aa4cd64519d891a340f6ce540..99e9741b6f871eeb6f0a16a640dffe03d4097b0a 100644 (file)
--- a/src/btree.c
+++ b/src/btree.c
@@ -3356,12 +3356,14 @@ static int modifyPagePointer(MemPage *pPage, Pgno iFrom, Pgno iTo, u8 eType){
       if( eType==PTRMAP_OVERFLOW1 ){
         CellInfo info;
         pPage->xParseCell(pPage, pCell, &info);
-        if( info.nLocal<info.nPayload
-         && pCell+info.nSize-1<=pPage->aData+pPage->maskPage
-         && iFrom==get4byte(pCell+info.nSize-4)
-        ){
-          put4byte(pCell+info.nSize-4, iTo);
-          break;
+        if( info.nLocal<info.nPayload ){
+          if( pCell+info.nSize > pPage->aData+pPage->pBt->usableSize ){
+            return SQLITE_CORRUPT_BKPT;
+          }
+          if( iFrom==get4byte(pCell+info.nSize-4) ){
+            put4byte(pCell+info.nSize-4, iTo);
+            break;
+          }
         }
       }else{
         if( get4byte(pCell)==iFrom ){