]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
misc: eeprom_93xx46: Use string_choices API instead of ternary operator
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 8 May 2024 18:47:02 +0000 (21:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jun 2024 15:47:08 +0000 (17:47 +0200)
Use modern string_choices API instead of manually determining the
output using ternary operator.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240508184905.2102633-10-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/eeprom_93xx46.c

index ac485b2827dbe26559659f941a631c76dbba5d0c..ad3b3bc054da5165aeaeea5165717fa321ab9abb 100644 (file)
@@ -18,6 +18,7 @@
 #include <linux/property.h>
 #include <linux/slab.h>
 #include <linux/spi/spi.h>
+#include <linux/string_choices.h>
 
 #include <linux/nvmem-provider.h>
 
@@ -200,8 +201,8 @@ static int eeprom_93xx46_ew(struct eeprom_93xx46_dev *edev, int is_on)
                bits += 2;
        }
 
-       dev_dbg(&edev->spi->dev, "ew%s cmd 0x%04x, %d bits\n",
-                       is_on ? "en" : "ds", cmd_addr, bits);
+       dev_dbg(&edev->spi->dev, "ew %s cmd 0x%04x, %d bits\n",
+               str_enable_disable(is_on), cmd_addr, bits);
 
        t.tx_buf = &cmd_addr;
        t.len = 2;
@@ -217,8 +218,8 @@ static int eeprom_93xx46_ew(struct eeprom_93xx46_dev *edev, int is_on)
        /* have to wait at least Tcsl ns */
        ndelay(250);
        if (ret)
-               dev_err(&edev->spi->dev, "erase/write %sable error %d\n",
-                       is_on ? "en" : "dis", ret);
+               dev_err(&edev->spi->dev, "erase/write %s error %d\n",
+                       str_enable_disable(is_on), ret);
 
        gpiod_set_value_cansleep(edev->pdata->select, 0);