thermal/drivers/brcmstb_thermal: Simplify with dev_err_probe()

dev_err_probe() is used to log an error message during the probe process
of a device.

It can simplify the error path and unify a message template.

Using this helper is totally fine even if err is known to never
be -EPROBE_DEFER.

The benefit compared to a normal dev_err() is the standardized format
of the error code, it being emitted symbolically and the fact that
the error code is returned which allows more compact error paths.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Link: https://lore.kernel.org/r/20240830103918.501234-1-yanzhen@vivo.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index 9674e5ffcfa274556fcb690fbe7d8dfd3c720718..270982740fded3381e504eb77b6d1190b852bfab 100644 (file)
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -338,11 +338,9 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
 
        thermal = devm_thermal_of_zone_register(&pdev->dev, 0, priv,
                                                of_ops);
-       if (IS_ERR(thermal)) {
-               ret = PTR_ERR(thermal);
-               dev_err(&pdev->dev, "could not register sensor: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(thermal))
+               return dev_err_probe(&pdev->dev, PTR_ERR(thermal),
+                                       "could not register sensor\n");
 
        priv->thermal = thermal;
 
@@ -352,10 +350,9 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
                                                brcmstb_tmon_irq_thread,
                                                IRQF_ONESHOT,
                                                DRV_NAME, priv);
-               if (ret < 0) {
-                       dev_err(&pdev->dev, "could not request IRQ: %d\n", ret);
-                       return ret;
-               }
+               if (ret < 0)
+                       return dev_err_probe(&pdev->dev, ret,
+                                               "could not request IRQ\n");
        }
 
        dev_info(&pdev->dev, "registered AVS TMON of-sensor driver\n");