firmware: turris-mox-rwtm: Use the boolean type where appropriate

Use the boolean type for has_board_info, has_pubkey and last_sig_done
members of the driver's private structure.

Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20240831092050.23093-4-kabel@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
index d3ce093d48350b276c0e35de8de3468761922fa1..8875c35f9b1932fa3b8e02b32dbd95c1f96ffd7d 100644 (file)
--- a/drivers/firmware/turris-mox-rwtm.c
+++ b/drivers/firmware/turris-mox-rwtm.c
@@ -19,6 +19,7 @@
 #include <linux/platform_device.h>
 #include <linux/sizes.h>
 #include <linux/slab.h>
+#include <linux/types.h>
 
 #define DRIVER_NAME            "turris-mox-rwtm"
 
@@ -67,13 +68,13 @@ struct mox_rwtm {
        struct completion cmd_done;
 
        /* board information */
-       int has_board_info;
+       bool has_board_info;
        u64 serial_number;
        int board_version, ram_size;
        u8 mac_address1[ETH_ALEN], mac_address2[ETH_ALEN];
 
        /* public key burned in eFuse */
-       int has_pubkey;
+       bool has_pubkey;
        u8 pubkey[135];
 
 #ifdef CONFIG_DEBUG_FS
@@ -85,7 +86,7 @@ struct mox_rwtm {
         */
        struct dentry *debugfs_root;
        u32 last_sig[34];
-       int last_sig_done;
+       bool last_sig_done;
 #endif
 };
 
@@ -229,7 +230,7 @@ static int mox_get_board_info(struct mox_rwtm *rwtm)
                                  reply->status[5]);
                reply_to_mac_addr(rwtm->mac_address2, reply->status[6],
                                  reply->status[7]);
-               rwtm->has_board_info = 1;
+               rwtm->has_board_info = true;
 
                pr_info("Turris Mox serial number %016llX\n",
                        rwtm->serial_number);
@@ -256,7 +257,7 @@ static int mox_get_board_info(struct mox_rwtm *rwtm)
        } else {
                u32 *s = reply->status;
 
-               rwtm->has_pubkey = 1;
+               rwtm->has_pubkey = true;
                sprintf(rwtm->pubkey,
                        "%06x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x",
                        ret, s[0], s[1], s[2], s[3], s[4], s[5], s[6], s[7],
@@ -352,7 +353,7 @@ static ssize_t do_sign_read(struct file *file, char __user *buf, size_t len,
 
        /* 2 arrays of 17 32-bit words are 136 bytes */
        ret = simple_read_from_buffer(buf, len, ppos, rwtm->last_sig, 136);
-       rwtm->last_sig_done = 0;
+       rwtm->last_sig_done = false;
 
        return ret;
 }
@@ -418,7 +419,7 @@ static ssize_t do_sign_write(struct file *file, const char __user *buf,
         */
        memcpy(rwtm->last_sig, rwtm->buf + 68, 136);
        cpu_to_be32_array(rwtm->last_sig, rwtm->last_sig, 34);
-       rwtm->last_sig_done = 1;
+       rwtm->last_sig_done = true;
 
        mutex_unlock(&rwtm->busy);
        return len;