]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq/amd-pstate: Remove the cppc_state check in offline/online functions
authorDhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Wed, 4 Dec 2024 14:48:41 +0000 (14:48 +0000)
committerMario Limonciello <mario.limonciello@amd.com>
Wed, 11 Dec 2024 16:44:52 +0000 (10:44 -0600)
Only amd_pstate_epp driver (i.e. cppc_state = ACTIVE) enters the
amd_pstate_epp_offline() and amd_pstate_epp_cpu_online() functions,
so remove the unnecessary if condition checking if cppc_state is
equal to AMD_PSTATE_ACTIVE.

Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Link: https://lore.kernel.org/r/20241204144842.164178-5-Dhananjay.Ugwekar@amd.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
drivers/cpufreq/amd-pstate.c

index 23c5840dc406989fa77afd8883be4b2ea1829de3..9b8d7f299fcaf53d3ff401e6f6295786f51a7c38 100644 (file)
@@ -1651,10 +1651,8 @@ static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy)
 
        pr_debug("AMD CPU Core %d going online\n", cpudata->cpu);
 
-       if (cppc_state == AMD_PSTATE_ACTIVE) {
-               amd_pstate_epp_reenable(cpudata);
-               cpudata->suspended = false;
-       }
+       amd_pstate_epp_reenable(cpudata);
+       cpudata->suspended = false;
 
        return 0;
 }
@@ -1683,8 +1681,7 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy)
        if (cpudata->suspended)
                return 0;
 
-       if (cppc_state == AMD_PSTATE_ACTIVE)
-               amd_pstate_epp_offline(policy);
+       amd_pstate_epp_offline(policy);
 
        return 0;
 }