]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: qcom: fix error code in snps_eusb2_hsphy_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 10 Jul 2025 17:24:02 +0000 (10:24 -0700)
committerVinod Koul <vkoul@kernel.org>
Tue, 15 Jul 2025 15:06:47 +0000 (20:36 +0530)
When phy->ref_clk is NULL PTR_ERR(NULL) will be a success. Fix this by
using -ENOENT when phy->ref_clk is NULL instead.

Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aDCbeuCTy9zyWJAM@stanley.mountain/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20250710172403.2593193-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-snps-eusb2.c

index b73a1d7e57b32cfdfbe314ab938ec54746ed53be..751b6d8ba2be2987e6c5584cf53240c79d9a7e76 100644 (file)
@@ -567,9 +567,11 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
                }
        }
 
-       if (IS_ERR_OR_NULL(phy->ref_clk))
-               return dev_err_probe(dev, PTR_ERR(phy->ref_clk),
+       if (IS_ERR_OR_NULL(phy->ref_clk)) {
+               ret = phy->ref_clk ? PTR_ERR(phy->ref_clk) : -ENOENT;
+               return dev_err_probe(dev, ret,
                                     "failed to get ref clk\n");
+       }
 
        num = ARRAY_SIZE(phy->vregs);
        for (i = 0; i < num; i++)