t-reftable-record: add comparison tests for ref records

In the current testing setup for ref records, the comparison
functions for ref records, reftable_ref_record_cmp_void() and
reftable_ref_record_equal() are left untested.

Add tests for the same by using the wrapper functions
reftable_record_cmp() and reftable_record_equal() for
reftable_ref_record_cmp_void() and reftable_ref_record_equal()
respectively.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Acked-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/unit-tests/t-reftable-record.c b/t/unit-tests/t-reftable-record.c
index dd64e71f3b6d0e64fd0998d525bb4375d14d5d28..99534acd17687872ace743adb6665e9695a13c21 100644 (file)
--- a/t/unit-tests/t-reftable-record.c
+++ b/t/unit-tests/t-reftable-record.c
@@ -63,6 +63,38 @@ static void set_hash(uint8_t *h, int j)
                h[i] = (j >> i) & 0xff;
 }
 
+static void t_reftable_ref_record_comparison(void)
+{
+       struct reftable_record in[3] = {
+               {
+                       .type = BLOCK_TYPE_REF,
+                       .u.ref.refname = (char *) "refs/heads/master",
+                       .u.ref.value_type = REFTABLE_REF_VAL1,
+               },
+               {
+                       .type = BLOCK_TYPE_REF,
+                       .u.ref.refname = (char *) "refs/heads/master",
+                       .u.ref.value_type = REFTABLE_REF_DELETION,
+               },
+               {
+                       .type = BLOCK_TYPE_REF,
+                       .u.ref.refname = (char *) "HEAD",
+                       .u.ref.value_type = REFTABLE_REF_SYMREF,
+                       .u.ref.value.symref = (char *) "refs/heads/master",
+               },
+       };
+
+       check(!reftable_record_equal(&in[0], &in[1], GIT_SHA1_RAWSZ));
+       check(!reftable_record_cmp(&in[0], &in[1]));
+
+       check(!reftable_record_equal(&in[1], &in[2], GIT_SHA1_RAWSZ));
+       check_int(reftable_record_cmp(&in[1], &in[2]), >, 0);
+
+       in[1].u.ref.value_type = in[0].u.ref.value_type;
+       check(reftable_record_equal(&in[0], &in[1], GIT_SHA1_RAWSZ));
+       check(!reftable_record_cmp(&in[0], &in[1]));
+}
+
 static void t_reftable_ref_record_roundtrip(void)
 {
        struct strbuf scratch = STRBUF_INIT;
@@ -371,6 +403,7 @@ static void t_reftable_index_record_roundtrip(void)
 
 int cmd_main(int argc, const char *argv[])
 {
+       TEST(t_reftable_ref_record_comparison(), "comparison operations work on ref record");
        TEST(t_reftable_log_record_comparison(), "comparison operations work on log record");
        TEST(t_reftable_log_record_roundtrip(), "record operations work on log record");
        TEST(t_reftable_ref_record_roundtrip(), "record operations work on ref record");