]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bus: bt1-apb: Use sysfs_streq instead of strncmp
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Thu, 28 May 2020 14:50:48 +0000 (17:50 +0300)
committerArnd Bergmann <arnd@arndb.de>
Thu, 28 May 2020 14:56:56 +0000 (16:56 +0200)
There is a ready-to-use method to compare a retrieved from a sysfs node
string with another string. It treats both NUL and newline-then-NUL as
equivalent string terminations. So use it instead of manually truncating
the line length in the strncmp() method.

Link: https://lore.kernel.org/r/20200528145050.5203-4-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/bus/bt1-apb.c

index 7e57fc2af745878fb8abdb40a8d9fb891aecd3fe..b25ff941e7c7f52c34f1050a403f5b28a11d7b2f 100644 (file)
@@ -325,9 +325,9 @@ static ssize_t inject_error_store(struct device *dev,
         * Either dummy read from the unmapped address in the APB IO area
         * or manually set the IRQ status.
         */
-       if (!strncmp(data, "nodev", 5))
+       if (sysfs_streq(data, "nodev"))
                readl(apb->res);
-       else if (!strncmp(data, "irq", 3))
+       else if (sysfs_streq(data, "irq"))
                regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
                                   APB_EHB_ISR_PENDING);
        else