Report errors from failed SQL queries

diff --git a/src/modules/rlm_sql/rlm_sql.c b/src/modules/rlm_sql/rlm_sql.c
index 20bd3fed677b9971dc85c6698563f9fa33e7c6b1..dbcc6627a0b2c89aa0baae4c65d1d524efb67bec 100644 (file)
--- a/src/modules/rlm_sql/rlm_sql.c
+++ b/src/modules/rlm_sql/rlm_sql.c
@@ -1070,6 +1070,7 @@ static unlang_action_t sql_get_grouplist_resume(unlang_result_t *p_result, reque
 
        if (query_ctx->rcode != RLM_SQL_OK) {
        error:
+               rlm_sql_print_error(inst, request, query_ctx, false);
                talloc_free(query_ctx);
                RETURN_UNLANG_FAIL;
        }
@@ -1807,12 +1808,14 @@ static unlang_action_t mod_sql_redundant_query_resume(unlang_result_t *p_result,
         *      so we do not need to call fr_pool_connection_release.
         */
        case RLM_SQL_RECONNECT:
+               rlm_sql_print_error(inst, request, query_ctx, false);
                RETURN_UNLANG_FAIL;
 
        /*
         *      Query was invalid, this is a terminal error.
         */
        case RLM_SQL_QUERY_INVALID:
+               rlm_sql_print_error(inst, request, query_ctx, false);
                RETURN_UNLANG_INVALID;
 
        /*

diff --git a/src/modules/rlm_sql/sql.c b/src/modules/rlm_sql/sql.c
index ca42378d4e286a5b16ce618e3cb145889da5c3a2..6c340b947535853acbbb40c90be7f1325e593724 100644 (file)
--- a/src/modules/rlm_sql/sql.c
+++ b/src/modules/rlm_sql/sql.c
@@ -309,7 +309,10 @@ static unlang_action_t sql_get_map_list_resume(unlang_result_t *p_result, reques
 
        rhs_rules.attr.list_def = request_attr_request;
 
-       if (query_ctx->rcode != RLM_SQL_OK) RETURN_UNLANG_FAIL;
+       if (query_ctx->rcode != RLM_SQL_OK) {
+               rlm_sql_print_error(inst, request, query_ctx, false);
+               RETURN_UNLANG_FAIL;
+       }
 
        while ((inst->fetch_row(p_result, request, query_ctx) == UNLANG_ACTION_CALCULATE_RESULT) &&
               (query_ctx->rcode == RLM_SQL_OK)) {