libxl: change xenDomainDefAddImplicitInputDevice() to return void

It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 680516092334cd38829f0246371df78c8fc489e1..c7ba5636c417b7cab0590b33c106a3a862aad17f 100644 (file)
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -266,8 +266,7 @@ libxlDomainDefPostParse(virDomainDef *def,
     }
 
     /* add implicit input devices */
-    if (xenDomainDefAddImplicitInputDevice(def) < 0)
-        return -1;
+    xenDomainDefAddImplicitInputDevice(def);
 
     /* For x86_64 HVM */
     if (def->os.type == VIR_DOMAIN_OSTYPE_HVM &&

diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c
index 2e02c2f790ebef9356c88c8cea10dcd54a3e61e7..a050f0ab6e800063ab645834a4e4a3ac5ed52d23 100644 (file)
--- a/src/libxl/xen_common.c
+++ b/src/libxl/xen_common.c
@@ -2388,7 +2388,7 @@ xenFormatConfigCommon(virConf *conf,
 }
 
 
-int
+void
 xenDomainDefAddImplicitInputDevice(virDomainDef *def)
 {
     virDomainInputBus implicitInputBus = VIR_DOMAIN_INPUT_BUS_XEN;
@@ -2398,6 +2398,4 @@ xenDomainDefAddImplicitInputDevice(virDomainDef *def)
 
     virDomainDefMaybeAddInput(def, VIR_DOMAIN_INPUT_TYPE_MOUSE, implicitInputBus);
     virDomainDefMaybeAddInput(def, VIR_DOMAIN_INPUT_TYPE_KBD, implicitInputBus);
-
-    return 0;
 }

diff --git a/src/libxl/xen_common.h b/src/libxl/xen_common.h
index 95408fa896c15e6ed016af281db4cc9aa6834ace..c52a4f12320d22d6bfe5c9c9636371432143626a 100644 (file)
--- a/src/libxl/xen_common.h
+++ b/src/libxl/xen_common.h
@@ -65,4 +65,4 @@ int xenFormatConfigCommon(virConf *conf,
 
 char *xenMakeIPList(virNetDevIPInfo *guestIP);
 
-int xenDomainDefAddImplicitInputDevice(virDomainDef *def);
+void xenDomainDefAddImplicitInputDevice(virDomainDef *def);