]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
libie: fix string names for AQ error codes
authorJacob Keller <jacob.e.keller@intel.com>
Tue, 23 Sep 2025 20:56:56 +0000 (13:56 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 24 Sep 2025 23:58:54 +0000 (16:58 -0700)
The LIBIE_AQ_STR macro() introduced by commit 5feaa7a07b85 ("libie: add
adminq helper for converting err to str") is used in order to generate
strings for printing human readable error codes. Its definition is missing
the separating underscore ('_') character which makes the resulting strings
difficult to read. Additionally, the string won't match the source code,
preventing search tools from working properly.

Add the missing underscore character, fixing the error string names.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Fixes: 5feaa7a07b85 ("libie: add adminq helper for converting err to str")
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20250923205657.846759-1-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/libie/adminq.c

index 55356548e3f0a16dec6bc5066bd9233deb4d95da..7b4ff479e7e57f1408364c556eafc5e083e551af 100644 (file)
@@ -6,7 +6,7 @@
 
 static const char * const libie_aq_str_arr[] = {
 #define LIBIE_AQ_STR(x)                                        \
-       [LIBIE_AQ_RC_##x]       = "LIBIE_AQ_RC" #x
+       [LIBIE_AQ_RC_##x]       = "LIBIE_AQ_RC_" #x
        LIBIE_AQ_STR(OK),
        LIBIE_AQ_STR(EPERM),
        LIBIE_AQ_STR(ENOENT),