]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Fix sysdeps/mips/dl-machine-reject-phdr.h build with GCC 16
authorJoseph Myers <josmyers@redhat.com>
Wed, 3 Sep 2025 16:04:49 +0000 (16:04 +0000)
committerJoseph Myers <josmyers@redhat.com>
Wed, 3 Sep 2025 16:04:49 +0000 (16:04 +0000)
Building for MIPS has been broken with GCC mainline since mid-July,
probably GCC commit 0eac9cfee8cb0b21de866a04d5d59685ab35208f "c, c++:
Extend -Wunused-but-set-* warnings [PR44677]", because the variable
perfect_match in elf_machine_reject_phdr_p is set unconditionally, but
only used if _MIPS_SIM == _ABIO32.  Mark it with __attribute__ ((unused)),
which seems cleaner in such a conditionally-used case than making all
other logic relating to this variable conditional.

Tested with build-many-glibcs.py (compilers build, which previously
failed) for mips64-linux-gnu.

sysdeps/mips/dl-machine-reject-phdr.h

index 72bb9087a8b63e1c099b64c9254a4412ffaa66a7..46852d241fc3fca77f9f2c5b7711a926b02f07fc 100644 (file)
@@ -162,7 +162,7 @@ elf_machine_reject_phdr_p (const ElfW(Phdr) *phdr, unsigned int phnum,
   int in_abi = -1;
   struct abi_req in_req;
   Elf_MIPS_ABIFlags_v0 mips_abiflags;
-  bool perfect_match = false;
+  bool perfect_match __attribute__ ((unused)) = false;
 #if _MIPS_SIM == _ABIO32
   unsigned int cur_mode = -1;
 # if HAVE_PRCTL_FP_MODE