]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t/lib-git-p4: use test_path_is_missing()
authorDenton Liu <liu.denton@gmail.com>
Fri, 20 Dec 2019 18:15:48 +0000 (10:15 -0800)
committerJunio C Hamano <gitster@pobox.com>
Fri, 20 Dec 2019 19:30:44 +0000 (11:30 -0800)
Previously, cleanup_git() would use `test_must_fail test -d` to ensure
that the directory is removed. However, test_must_fail should only be
used for git commands. Use test_path_is_missing() instead to check that
the directory has been removed.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-git-p4.sh

index 547b9f88e1235a9248f6da9d1fa24dffd7cb0cd3..5aff2abe8b5490156e7745beb5ad01d9cacc0d58 100644 (file)
@@ -175,7 +175,7 @@ stop_and_cleanup_p4d () {
 
 cleanup_git () {
        retry_until_success rm -r "$git"
-       test_must_fail test -d "$git" &&
+       test_path_is_missing "$git" &&
        retry_until_success mkdir "$git"
 }