]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/sitronix: st7571-i2c: Select VIDEOMODE_HELPERS
authorNathan Chancellor <nathan@kernel.org>
Tue, 10 Jun 2025 19:40:38 +0000 (12:40 -0700)
committerMaxime Ripard <mripard@kernel.org>
Wed, 11 Jun 2025 08:44:56 +0000 (10:44 +0200)
This driver requires of_get_display_timing() from
CONFIG_VIDEOMODE_HELPERS but does not select it. If no other driver
selects it, there will be a failure from the linker if the driver is
built in or modpost if it is a module.

  ERROR: modpost: "of_get_display_timing" [drivers/gpu/drm/sitronix/st7571-i2c.ko] undefined!

Select CONFIG_VIDEOMODE_HELPERS to resolve the build failure.

Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20250610-drm-st7571-i2c-select-videomode-helpers-v1-1-d30b50ff6e64@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/sitronix/Kconfig

index c069d0d417753bcf62343bd2456b5b98d60b730b..741d1bb4b83f7f3e77582fe648661ce0b7e91e0b 100644 (file)
@@ -5,6 +5,7 @@ config DRM_ST7571_I2C
        select DRM_GEM_SHMEM_HELPER
        select DRM_KMS_HELPER
        select REGMAP_I2C
+       select VIDEOMODE_HELPERS
        help
          DRM driver for Sitronix ST7571 panels controlled over I2C.