USB: ehci-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 3ed75aaa09d9d37b786c7865af231274fa8d4542..7619cfb068836e6a95722caae82ae9f670976a03 100644 (file)
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -1028,29 +1028,15 @@ static inline void create_debug_files(struct ehci_hcd *ehci)
        struct usb_bus *bus = &ehci_to_hcd(ehci)->self;
 
        ehci->debug_dir = debugfs_create_dir(bus->bus_name, ehci_debug_root);
-       if (!ehci->debug_dir)
-               return;
 
-       if (!debugfs_create_file("async", S_IRUGO, ehci->debug_dir, bus,
-                                               &debug_async_fops))
-               goto file_error;
-
-       if (!debugfs_create_file("bandwidth", S_IRUGO, ehci->debug_dir, bus,
-                                               &debug_bandwidth_fops))
-               goto file_error;
-
-       if (!debugfs_create_file("periodic", S_IRUGO, ehci->debug_dir, bus,
-                                               &debug_periodic_fops))
-               goto file_error;
-
-       if (!debugfs_create_file("registers", S_IRUGO, ehci->debug_dir, bus,
-                                                   &debug_registers_fops))
-               goto file_error;
-
-       return;
-
-file_error:
-       debugfs_remove_recursive(ehci->debug_dir);
+       debugfs_create_file("async", S_IRUGO, ehci->debug_dir, bus,
+                           &debug_async_fops);
+       debugfs_create_file("bandwidth", S_IRUGO, ehci->debug_dir, bus,
+                           &debug_bandwidth_fops);
+       debugfs_create_file("periodic", S_IRUGO, ehci->debug_dir, bus,
+                           &debug_periodic_fops);
+       debugfs_create_file("registers", S_IRUGO, ehci->debug_dir, bus,
+                           &debug_registers_fops);
 }
 
 static inline void remove_debug_files(struct ehci_hcd *ehci)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index d927adf3afcd95db2662f23f0090ecf5e6b7383f..89c47ae5c7d322c9581bcad1e5b1446e27569f1a 100644 (file)
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -1311,10 +1311,6 @@ static int __init ehci_hcd_init(void)
 
 #ifdef CONFIG_DYNAMIC_DEBUG
        ehci_debug_root = debugfs_create_dir("ehci", usb_debug_root);
-       if (!ehci_debug_root) {
-               retval = -ENOENT;
-               goto err_debug;
-       }
 #endif
 
 #ifdef PLATFORM_DRIVER
@@ -1361,7 +1357,6 @@ clean0:
 #ifdef CONFIG_DYNAMIC_DEBUG
        debugfs_remove(ehci_debug_root);
        ehci_debug_root = NULL;
-err_debug:
 #endif
        clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
        return retval;