]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp...
authorAthira Rajeev <atrajeev@linux.vnet.ibm.com>
Sun, 23 Jun 2024 06:48:49 +0000 (12:18 +0530)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 25 Jun 2024 18:01:34 +0000 (11:01 -0700)
commit 80d496be89ed ("perf report: Add support for profiling JIT
generated code") added support for profiling JIT generated code.
This patch handles dso's of form "/tmp/perf-$PID.map".

Some of the references doesn't check exactly for same pattern.
some uses "if (!strncmp(dso_name, "/tmp/perf-", 10))". Fix
this by using helper function perf_pid_map_tid and
is_perf_pid_map_name which looks for proper pattern of
form: "/tmp/perf-$PID.map" for these checks.

Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: akanksha@linux.ibm.com
Cc: kjain@linux.ibm.com
Cc: maddy@linux.ibm.com
Cc: disgoel@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240623064850.83720-2-atrajeev@linux.vnet.ibm.com
tools/perf/util/dsos.c
tools/perf/util/srcline.c

index ab3d0c01dd63971199659c22624e7d38d2ed2a9a..846828ea1f00b1c114679aed56c6f42d536fd5e0 100644 (file)
@@ -275,7 +275,7 @@ static void dso__set_basename(struct dso *dso)
        char *base, *lname;
        int tid;
 
-       if (sscanf(dso__long_name(dso), "/tmp/perf-%d.map", &tid) == 1) {
+       if (perf_pid_map_tid(dso__long_name(dso), &tid)) {
                if (asprintf(&base, "[JIT] tid %d", tid) < 0)
                        return;
        } else {
index 9d670d8c1c089567e1f46308bffe98357806aaf5..51eb78993fe22154d00b20dedc6f2b512efa3119 100644 (file)
@@ -39,7 +39,7 @@ static const char *srcline_dso_name(struct dso *dso)
        if (dso_name[0] == '[')
                return NULL;
 
-       if (!strncmp(dso_name, "/tmp/perf-", 10))
+       if (is_perf_pid_map_name(dso_name))
                return NULL;
 
        return dso_name;