]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: hide unused is_valid_bugaddr()
authorArnd Bergmann <arnd@arndb.de>
Tue, 16 May 2023 16:06:36 +0000 (18:06 +0200)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 25 May 2023 16:44:02 +0000 (17:44 +0100)
When generic BUG() support is disabled, this function has no declaration
and no callers but causes a W=1 warning:

arch/arm64/kernel/traps.c:950:5: error: no previous prototype for 'is_valid_bugaddr' [-Werror=missing-prototypes]

Add an #ifdef that matches the one around the declaration.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20230516160642.523862-10-arnd@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/traps.c

index 4bb1b8f472982004e9171956c0b581d10be058b0..720d3780d8fd1e8e6d3b978914e2bc8f5d12ebd0 100644 (file)
@@ -947,7 +947,7 @@ void do_serror(struct pt_regs *regs, unsigned long esr)
 }
 
 /* GENERIC_BUG traps */
-
+#ifdef CONFIG_GENERIC_BUG
 int is_valid_bugaddr(unsigned long addr)
 {
        /*
@@ -959,6 +959,7 @@ int is_valid_bugaddr(unsigned long addr)
         */
        return 1;
 }
+#endif
 
 static int bug_handler(struct pt_regs *regs, unsigned long esr)
 {