]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: pci200syn: replace comparison to NULL with "!card"
authorPeng Li <lipeng321@huawei.com>
Tue, 15 Jun 2021 13:54:20 +0000 (21:54 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Jun 2021 18:03:17 +0000 (11:03 -0700)
According to the chackpatch.pl, comparison to NULL could
be written "!card".

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/pci200syn.c

index a7eac9099de94385246c0ad81b68c8981125500e..cee3d658a3e84f65bc9d76064ca5fe722e2eb862 100644 (file)
@@ -279,7 +279,7 @@ static int pci200_pci_init_one(struct pci_dev *pdev,
        }
 
        card = kzalloc(sizeof(card_t), GFP_KERNEL);
-       if (card == NULL) {
+       if (!card) {
                pci_release_regions(pdev);
                pci_disable_device(pdev);
                return -ENOBUFS;
@@ -310,9 +310,7 @@ static int pci200_pci_init_one(struct pci_dev *pdev,
        ramphys = pci_resource_start(pdev,3) & PCI_BASE_ADDRESS_MEM_MASK;
        card->rambase = pci_ioremap_bar(pdev, 3);
 
-       if (card->plxbase == NULL ||
-           card->scabase == NULL ||
-           card->rambase == NULL) {
+       if (!card->plxbase || !card->scabase || !card->rambase) {
                pr_err("ioremap() failed\n");
                pci200_pci_remove_one(pdev);
                return -EFAULT;