]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
6.6-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2024 17:50:38 +0000 (19:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2024 17:50:38 +0000 (19:50 +0200)
added patches:
drm-amd-display-add-hdr-workaround-for-specific-edp.patch
drm-amd-display-fix-system-hang-while-resume-with-tbt-monitor.patch
drm-i915-gem-fix-bitwise-and-logical-and-mixup.patch
drm-sched-add-locking-to-drm_sched_entity_modify_sched.patch

queue-6.6/drm-amd-display-add-hdr-workaround-for-specific-edp.patch [new file with mode: 0644]
queue-6.6/drm-amd-display-fix-system-hang-while-resume-with-tbt-monitor.patch [new file with mode: 0644]
queue-6.6/drm-i915-gem-fix-bitwise-and-logical-and-mixup.patch [new file with mode: 0644]
queue-6.6/drm-sched-add-locking-to-drm_sched_entity_modify_sched.patch [new file with mode: 0644]
queue-6.6/series

diff --git a/queue-6.6/drm-amd-display-add-hdr-workaround-for-specific-edp.patch b/queue-6.6/drm-amd-display-add-hdr-workaround-for-specific-edp.patch
new file mode 100644 (file)
index 0000000..4627a84
--- /dev/null
@@ -0,0 +1,79 @@
+From 05af800704ee7187d9edd461ec90f3679b1c4aba Mon Sep 17 00:00:00 2001
+From: Alex Hung <alex.hung@amd.com>
+Date: Fri, 6 Sep 2024 11:39:18 -0600
+Subject: drm/amd/display: Add HDR workaround for specific eDP
+
+From: Alex Hung <alex.hung@amd.com>
+
+commit 05af800704ee7187d9edd461ec90f3679b1c4aba upstream.
+
+[WHY & HOW]
+Some eDP panels suffer from flicking when HDR is enabled in KDE. This
+quirk works around it by skipping VSC that is incompatible with eDP
+panels.
+
+Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3151
+Cc: Mario Limonciello <mario.limonciello@amd.com>
+Cc: Alex Deucher <alexander.deucher@amd.com>
+Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
+Signed-off-by: Alex Hung <alex.hung@amd.com>
+Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
+Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
+Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
+(cherry picked from commit 4d4257280d7957727998ef90ccc7b69c7cca8376)
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c         |   11 ++++++++++-
+ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c |    4 ++++
+ drivers/gpu/drm/amd/display/dc/dc_types.h                 |    1 +
+ 3 files changed, 15 insertions(+), 1 deletion(-)
+
+--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
++++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+@@ -6153,12 +6153,21 @@ create_stream_for_sink(struct amdgpu_dm_
+       if (stream->signal == SIGNAL_TYPE_DISPLAY_PORT ||
+           stream->signal == SIGNAL_TYPE_DISPLAY_PORT_MST ||
+           stream->signal == SIGNAL_TYPE_EDP) {
++              const struct dc_edid_caps *edid_caps;
++              unsigned int disable_colorimetry = 0;
++
++              if (aconnector->dc_sink) {
++                      edid_caps = &aconnector->dc_sink->edid_caps;
++                      disable_colorimetry = edid_caps->panel_patch.disable_colorimetry;
++              }
++
+               //
+               // should decide stream support vsc sdp colorimetry capability
+               // before building vsc info packet
+               //
+               stream->use_vsc_sdp_for_colorimetry = stream->link->dpcd_caps.dpcd_rev.raw >= 0x14 &&
+-                                                    stream->link->dpcd_caps.dprx_feature.bits.VSC_SDP_COLORIMETRY_SUPPORTED;
++                                                    stream->link->dpcd_caps.dprx_feature.bits.VSC_SDP_COLORIMETRY_SUPPORTED &&
++                                                    !disable_colorimetry;
+               if (stream->out_transfer_func->tf == TRANSFER_FUNCTION_GAMMA22)
+                       tf = TRANSFER_FUNC_GAMMA_22;
+--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
++++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+@@ -71,6 +71,10 @@ static void apply_edid_quirks(struct edi
+               DRM_DEBUG_DRIVER("Clearing DPCD 0x317 on monitor with panel id %X\n", panel_id);
+               edid_caps->panel_patch.remove_sink_ext_caps = true;
+               break;
++      case drm_edid_encode_panel_id('S', 'D', 'C', 0x4154):
++              DRM_DEBUG_DRIVER("Disabling VSC on monitor with panel id %X\n", panel_id);
++              edid_caps->panel_patch.disable_colorimetry = true;
++              break;
+       default:
+               return;
+       }
+--- a/drivers/gpu/drm/amd/display/dc/dc_types.h
++++ b/drivers/gpu/drm/amd/display/dc/dc_types.h
+@@ -190,6 +190,7 @@ struct dc_panel_patch {
+       unsigned int skip_avmute;
+       unsigned int mst_start_top_delay;
+       unsigned int remove_sink_ext_caps;
++      unsigned int disable_colorimetry;
+ };
+ struct dc_edid_caps {
diff --git a/queue-6.6/drm-amd-display-fix-system-hang-while-resume-with-tbt-monitor.patch b/queue-6.6/drm-amd-display-fix-system-hang-while-resume-with-tbt-monitor.patch
new file mode 100644 (file)
index 0000000..fa08bf0
--- /dev/null
@@ -0,0 +1,50 @@
+From 52d4e3fb3d340447dcdac0e14ff21a764f326907 Mon Sep 17 00:00:00 2001
+From: Tom Chung <chiahsuan.chung@amd.com>
+Date: Fri, 13 Sep 2024 15:44:40 +0800
+Subject: drm/amd/display: Fix system hang while resume with TBT monitor
+
+From: Tom Chung <chiahsuan.chung@amd.com>
+
+commit 52d4e3fb3d340447dcdac0e14ff21a764f326907 upstream.
+
+[Why]
+Connected with a Thunderbolt monitor and do the suspend and the system
+may hang while resume.
+
+The TBT monitor HPD will be triggered during the resume procedure
+and call the drm_client_modeset_probe() while
+struct drm_connector connector->dev->master is NULL.
+
+It will mess up the pipe topology after resume.
+
+[How]
+Skip the TBT monitor HPD during the resume procedure because we
+currently will probe the connectors after resume by default.
+
+Reviewed-by: Wayne Lin <wayne.lin@amd.com>
+Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
+Signed-off-by: Fangzhi Zuo <jerry.zuo@amd.com>
+Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
+Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
+(cherry picked from commit 453f86a26945207a16b8f66aaed5962dc2b95b85)
+Cc: stable@vger.kernel.org
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    6 ++++++
+ 1 file changed, 6 insertions(+)
+
+--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
++++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+@@ -714,6 +714,12 @@ static void dmub_hpd_callback(struct amd
+               return;
+       }
++      /* Skip DMUB HPD IRQ in suspend/resume. We will probe them later. */
++      if (notify->type == DMUB_NOTIFICATION_HPD && adev->in_suspend) {
++              DRM_INFO("Skip DMUB HPD IRQ callback in suspend/resume\n");
++              return;
++      }
++
+       link_index = notify->link_index;
+       link = adev->dm.dc->links[link_index];
+       dev = adev->dm.ddev;
diff --git a/queue-6.6/drm-i915-gem-fix-bitwise-and-logical-and-mixup.patch b/queue-6.6/drm-i915-gem-fix-bitwise-and-logical-and-mixup.patch
new file mode 100644 (file)
index 0000000..cbbf9ae
--- /dev/null
@@ -0,0 +1,48 @@
+From 394b52462020b6cceff1f7f47fdebd03589574f3 Mon Sep 17 00:00:00 2001
+From: Jani Nikula <jani.nikula@intel.com>
+Date: Wed, 18 Sep 2024 20:35:43 +0300
+Subject: drm/i915/gem: fix bitwise and logical AND mixup
+
+From: Jani Nikula <jani.nikula@intel.com>
+
+commit 394b52462020b6cceff1f7f47fdebd03589574f3 upstream.
+
+CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When
+the wakeref is non-zero, it's either -1 or a dynamically allocated
+pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that
+the code works by coincidence with the bitwise AND, but with
+CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y, there's the off chance that the
+condition evaluates to false, and intel_wakeref_auto() doesn't get
+called. Switch to the intended logical AND.
+
+v2: Use != to avoid clang -Wconstant-logical-operand (Nathan)
+
+Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
+Cc: Matthew Auld <matthew.auld@intel.com>
+Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
+Cc: Anshuman Gupta <anshuman.gupta@intel.com>
+Cc: Andi Shyti <andi.shyti@linux.intel.com>
+Cc: Nathan Chancellor <nathan@kernel.org>
+Cc: stable@vger.kernel.org # v6.1+
+Reviewed-by: Matthew Auld <matthew.auld@intel.com>
+Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> # v1
+Link: https://patchwork.freedesktop.org/patch/msgid/643cc0a4d12f47fd8403d42581e83b1e9c4543c7.1726680898.git.jani.nikula@intel.com
+Signed-off-by: Jani Nikula <jani.nikula@intel.com>
+(cherry picked from commit 4c1bfe259ed1d2ade826f95d437e1c41b274df04)
+Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/gpu/drm/i915/gem/i915_gem_ttm.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
++++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+@@ -1136,7 +1136,7 @@ static vm_fault_t vm_fault_ttm(struct vm
+               GEM_WARN_ON(!i915_ttm_cpu_maps_iomem(bo->resource));
+       }
+-      if (wakeref & CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND)
++      if (wakeref && CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND != 0)
+               intel_wakeref_auto(&to_i915(obj->base.dev)->runtime_pm.userfault_wakeref,
+                                  msecs_to_jiffies_timeout(CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND));
diff --git a/queue-6.6/drm-sched-add-locking-to-drm_sched_entity_modify_sched.patch b/queue-6.6/drm-sched-add-locking-to-drm_sched_entity_modify_sched.patch
new file mode 100644 (file)
index 0000000..a41152f
--- /dev/null
@@ -0,0 +1,52 @@
+From 4286cc2c953983d44d248c9de1c81d3a9643345c Mon Sep 17 00:00:00 2001
+From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
+Date: Fri, 13 Sep 2024 17:05:52 +0100
+Subject: drm/sched: Add locking to drm_sched_entity_modify_sched
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
+
+commit 4286cc2c953983d44d248c9de1c81d3a9643345c upstream.
+
+Without the locking amdgpu currently can race between
+amdgpu_ctx_set_entity_priority() (via drm_sched_entity_modify_sched()) and
+drm_sched_job_arm(), leading to the latter accesing potentially
+inconsitent entity->sched_list and entity->num_sched_list pair.
+
+v2:
+ * Improve commit message. (Philipp)
+
+Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
+Fixes: b37aced31eb0 ("drm/scheduler: implement a function to modify sched list")
+Cc: Christian König <christian.koenig@amd.com>
+Cc: Alex Deucher <alexander.deucher@amd.com>
+Cc: Luben Tuikov <ltuikov89@gmail.com>
+Cc: Matthew Brost <matthew.brost@intel.com>
+Cc: David Airlie <airlied@gmail.com>
+Cc: Daniel Vetter <daniel@ffwll.ch>
+Cc: dri-devel@lists.freedesktop.org
+Cc: Philipp Stanner <pstanner@redhat.com>
+Cc: <stable@vger.kernel.org> # v5.7+
+Reviewed-by: Christian König <christian.koenig@amd.com>
+Link: https://patchwork.freedesktop.org/patch/msgid/20240913160559.49054-2-tursulin@igalia.com
+Signed-off-by: Christian König <christian.koenig@amd.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/gpu/drm/scheduler/sched_entity.c |    2 ++
+ 1 file changed, 2 insertions(+)
+
+--- a/drivers/gpu/drm/scheduler/sched_entity.c
++++ b/drivers/gpu/drm/scheduler/sched_entity.c
+@@ -111,8 +111,10 @@ void drm_sched_entity_modify_sched(struc
+ {
+       WARN_ON(!num_sched_list || !sched_list);
++      spin_lock(&entity->rq_lock);
+       entity->sched_list = sched_list;
+       entity->num_sched_list = num_sched_list;
++      spin_unlock(&entity->rq_lock);
+ }
+ EXPORT_SYMBOL(drm_sched_entity_modify_sched);
index 1c9a86d4c6337e1922ff7ff933c9df08e6f90e04..360990134f0786f5bc08f8cea524e17da3b592e7 100644 (file)
@@ -321,3 +321,7 @@ tracing-timerlat-fix-a-race-during-cpuhp-processing.patch
 tracing-timerlat-fix-duplicated-kthread-creation-due-to-cpu-online-offline.patch
 rtla-fix-the-help-text-in-osnoise-and-timerlat-top-tools.patch
 close_range-fix-the-logics-in-descriptor-table-trimming.patch
+drm-i915-gem-fix-bitwise-and-logical-and-mixup.patch
+drm-sched-add-locking-to-drm_sched_entity_modify_sched.patch
+drm-amd-display-add-hdr-workaround-for-specific-edp.patch
+drm-amd-display-fix-system-hang-while-resume-with-tbt-monitor.patch