Add conditional support to display users real name in bug reports if user

entered in that information. Thanks to
Chris Baldwin <cbaldwin@redback.com>
for providing the patch.

diff --git a/bug_form.pl b/bug_form.pl
index 1402a1a470e42fd581dcb4cd301cf34f4deb3de3..735dd2f1d063c27a54e59eab4739d20f285d6f2b 100644 (file)
--- a/bug_form.pl
+++ b/bug_form.pl
@@ -118,6 +118,9 @@ my $assignedtoid = $bug{'assigned_to'};
 my $reporterid = $bug{'reporter'};
 my $qacontactid =  $bug{'qa_contact'};
 
+
+$bug{'assigned_name'} = DBID_to_real_name($bug{'assigned_to'});
+$bug{'reporter_name'} = DBID_to_real_name($bug{'reporter'});
 $bug{'assigned_to'} = DBID_to_name($bug{'assigned_to'});
 $bug{'reporter'} = DBID_to_name($bug{'reporter'});
 
@@ -183,8 +186,8 @@ print "
     <TD ALIGN=RIGHT><B>OS:</B></TD>
     <TD><SELECT NAME=op_sys>" .
     make_options(\@::legal_opsys, $bug{'op_sys'}) .
-    "</SELECT><TD ALIGN=RIGHT><B>Reporter:</B></TD><TD>$bug{'reporter'}</TD>
-  </TR><TR>
+    "</SELECT><TD ALIGN=RIGHT><B>Reporter:</B></TD><TD>$bug{'reporter'} $bug{'reporter_name'}</TD>
+     </TDTR><TR>
     <TD ALIGN=RIGHT><B><A HREF=\"bug_status.html\">Status:</A></B></TD>
       <TD>$bug{'bug_status'}</TD>
     <TD ALIGN=RIGHT><B><A HREF=\"bug_status.html#priority\">Priority:</A></B></TD>
@@ -202,7 +205,7 @@ print "
   </TR><TR>
     <TD ALIGN=RIGHT><B><A HREF=\"bug_status.html#assigned_to\">Assigned&nbsp;To:
         </A></B></TD>
-      <TD>$bug{'assigned_to'}</TD>";
+      <TD>$bug{'assigned_to'} $bug{'assigned_name'}</TD>";
 
 if (Param("usetargetmilestone")) {
     my $url = "";

diff --git a/globals.pl b/globals.pl
index 2d22038a3db3dc2c9c38db9426222f79f3c2e0af..948fa7feb69c4a6cc6e49f277dbd9532ee32eb98 100644 (file)
--- a/globals.pl
+++ b/globals.pl
@@ -546,6 +546,16 @@ sub InsertNewUser {
     return $password;
 }
 
+sub DBID_to_real_name {
+    my ($id) = (@_);
+    SendSQL("SELECT realname FROM profiles WHERE userid = $id");
+    my ($r) = FetchSQLData();
+    if ($r eq "") {
+        return;
+    } else {
+        return "($r)";
+    }
+}
 
 sub DBID_to_name {
     my ($id) = (@_);
@@ -721,7 +731,7 @@ sub GetLongDescriptionAsHTML {
         $knownattachments{FetchOneColumn()} = 1;
     }
 
-    my ($query) = ("SELECT profiles.login_name, longdescs.bug_when, " .
+    my ($query) = ("SELECT profiles.realname, profiles.login_name, longdescs.bug_when, " .
                    "       longdescs.thetext " .
                    "FROM longdescs, profiles " .
                    "WHERE profiles.userid = longdescs.who " .
@@ -740,12 +750,18 @@ sub GetLongDescriptionAsHTML {
     $query .= "ORDER BY longdescs.bug_when";
     SendSQL($query);
     while (MoreSQLData()) {
-        my ($who, $when, $text) = (FetchSQLData());
+        my ($who, $email, $when, $text) = (FetchSQLData());
         if ($count) {
-            $result .= "<BR><BR><I>------- Additional Comments From " .
-                qq{<A HREF="mailto:$who">$who</A> } .
-                    time2str("%Y-%m-%d %H:%M", str2time($when)) .
-                        " -------</I><BR>\n";
+            $result .= "<BR><BR><I>------- Additional Comments From ";
+              if ($who) {
+                  $result .= qq{<A HREF="mailto:$email">$who</A> } .
+                      time2str("%Y-%m-%d %H:%M", str2time($when)) .
+                          " -------</I><BR>\n";
+              } else {
+                  $result .= qq{<A HREF="mailto:$email">$email</A> } .
+                      time2str("%Y-%m-%d %H:%M", str2time($when)) .
+                          " -------</I><BR>\n";
+              }
         }
         $result .= "<PRE>" . quoteUrls(\%knownattachments, $text) . "</PRE>\n";
         $count++;