]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nvmet: pci-epf: Remove redundant 'flush_workqueue()' calls
authorChen Ni <nichen@iscas.ac.cn>
Wed, 12 Mar 2025 08:56:25 +0000 (16:56 +0800)
committerKeith Busch <kbusch@kernel.org>
Thu, 20 Mar 2025 23:53:55 +0000 (16:53 -0700)
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- flush_workqueue(E);
  destroy_workqueue(E);

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/pci-epf.c

index ac30b42cc6221470c7f007b27e84dfdfdcbc14fc..a7c40a674df604509ef9f5189e7f278814963aaf 100644 (file)
@@ -1385,7 +1385,6 @@ static u16 nvmet_pci_epf_delete_sq(struct nvmet_ctrl *tctrl, u16 sqid)
        if (!test_and_clear_bit(NVMET_PCI_EPF_Q_LIVE, &sq->flags))
                return NVME_SC_QID_INVALID | NVME_STATUS_DNR;
 
-       flush_workqueue(sq->iod_wq);
        destroy_workqueue(sq->iod_wq);
        sq->iod_wq = NULL;