__attribute__: mark some functions with LAST_ARG_MUST_BE_NULL

Some varargs functions that use NULL-terminated parameter list were
missing __attributes__ ((sentinel)) aka LAST_ARG_MUST_BE_NULL.

Add them.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/add-patch.c b/add-patch.c
index 0997d4af7398a2fe51e702d3ba4b24e7794d0047..b2fbd8cbf387c1d4f8356dd3c9b3210dfd616ebd 100644 (file)
--- a/add-patch.c
+++ b/add-patch.c
@@ -300,6 +300,7 @@ static void err(struct add_p_state *s, const char *fmt, ...)
        va_end(args);
 }
 
+LAST_ARG_MUST_BE_NULL
 static void setup_child_process(struct add_p_state *s,
                                struct child_process *cp, ...)
 {

diff --git a/attr.h b/attr.h
index 127998ae013c9de221b700144ad2082a78bfcaba..afa33ce3be6e96fc77717fd98eed57ee77135def 100644 (file)
--- a/attr.h
+++ b/attr.h
@@ -190,6 +190,8 @@ struct attr_check {
 };
 
 struct attr_check *attr_check_alloc(void);
+
+LAST_ARG_MUST_BE_NULL
 struct attr_check *attr_check_initl(const char *, ...);
 struct attr_check *attr_check_dup(const struct attr_check *check);
 

diff --git a/hook.h b/hook.h
index 19ab9a5806e1c1de11f7b300471c957fa5e6b4d4..6511525aebb77bb2cef099077cd0b85091e9ed32 100644 (file)
--- a/hook.h
+++ b/hook.h
@@ -86,5 +86,6 @@ int run_hooks(const char *hook_name);
  * argument. These things will be used as positional arguments to the
  * hook. This function behaves like the old run_hook_le() API.
  */
+LAST_ARG_MUST_BE_NULL
 int run_hooks_l(const char *hook_name, ...);
 #endif

diff --git a/scalar.c b/scalar.c
index fb2940c2a00c94d806319dc8d45e8ffed1231c17..552ac8f0d98e370f1912ec291b3f22c92b4950a8 100644 (file)
--- a/scalar.c
+++ b/scalar.c
@@ -70,6 +70,7 @@ static void setup_enlistment_directory(int argc, const char **argv,
        strbuf_release(&path);
 }
 
+LAST_ARG_MUST_BE_NULL
 static int run_git(const char *arg, ...)
 {
        struct child_process cmd = CHILD_PROCESS_INIT;