]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: Accept a const xe device
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 22 Sep 2023 17:43:20 +0000 (10:43 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:41:16 +0000 (11:41 -0500)
Depending on the context, it's preferred to have a const pointer to make
sure nothing is modified underneath. The assert macros only ever read
data from xe/tile/gt for printing, so they can be made const by default.

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Link: https://lore.kernel.org/r/20230922174320.2372617-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_assert.h

index 962aac1bc76480ad753c9cf80ba58a9621e053ef..34c142e6cfb0938b458157dcfb621079074b6c4e 100644 (file)
@@ -86,7 +86,7 @@
 })
 #else
 #define __xe_assert_msg(xe, condition, msg, arg...) ({                                         \
-       typecheck(struct xe_device *, xe);                                                      \
+       typecheck(const struct xe_device *, xe);                                                \
        BUILD_BUG_ON_INVALID(condition);                                                        \
 })
 #endif
  */
 #define xe_assert(xe, condition) xe_assert_msg((xe), condition, "")
 #define xe_assert_msg(xe, condition, msg, arg...) ({                                           \
-       struct xe_device *__xe = (xe);                                                          \
+       const struct xe_device *__xe = (xe);                                                    \
        __xe_assert_msg(__xe, condition,                                                        \
                        "platform: %d subplatform: %d\n"                                        \
                        "graphics: %s %u.%02u step %s\n"                                        \
  */
 #define xe_tile_assert(tile, condition) xe_tile_assert_msg((tile), condition, "")
 #define xe_tile_assert_msg(tile, condition, msg, arg...) ({                                    \
-       struct xe_tile *__tile = (tile);                                                        \
+       const struct xe_tile *__tile = (tile);                                                  \
        char __buf[10] __maybe_unused;                                                          \
        xe_assert_msg(tile_to_xe(__tile), condition, "tile: %u VRAM %s\n" msg,                  \
                      __tile->id, ({ string_get_size(__tile->mem.vram.actual_physical_size, 1,  \
  */
 #define xe_gt_assert(gt, condition) xe_gt_assert_msg((gt), condition, "")
 #define xe_gt_assert_msg(gt, condition, msg, arg...) ({                                                \
-       struct xe_gt *__gt = (gt);                                                              \
+       const struct xe_gt *__gt = (gt);                                                        \
        xe_tile_assert_msg(gt_to_tile(__gt), condition, "GT: %u type %d\n" msg,                 \
                           __gt->info.id, __gt->info.type, ## arg);                             \
 })