]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915: remove unused arg in skl_scaler_get_filter_select()
authorLuca Coelho <luciano.coelho@intel.com>
Tue, 20 May 2025 08:26:59 +0000 (11:26 +0300)
committerMika Kahola <mika.kahola@intel.com>
Thu, 5 Jun 2025 12:37:51 +0000 (15:37 +0300)
We always pass 0 in the set argument of skl_scaler_get_filter_select()
calls, so the argument is unnecessary.  Remove it.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Link: https://lore.kernel.org/r/20250520082917.1302665-3-luciano.coelho@intel.com
drivers/gpu/drm/i915/display/skl_scaler.c

index c855426544cf2523a1bc3bcdb3b791924203879e..9cbfddb8556a352c0841040aa27a1962ac9d456f 100644 (file)
@@ -695,15 +695,14 @@ static void glk_program_nearest_filter_coefs(struct intel_display *display,
                           GLK_PS_COEF_INDEX_SET(pipe, id, set), 0);
 }
 
-static u32 skl_scaler_get_filter_select(enum drm_scaling_filter filter, int set)
+static u32 skl_scaler_get_filter_select(enum drm_scaling_filter filter)
 {
-       if (filter == DRM_SCALING_FILTER_NEAREST_NEIGHBOR) {
+       if (filter == DRM_SCALING_FILTER_NEAREST_NEIGHBOR)
                return (PS_FILTER_PROGRAMMED |
-                       PS_Y_VERT_FILTER_SELECT(set) |
-                       PS_Y_HORZ_FILTER_SELECT(set) |
-                       PS_UV_VERT_FILTER_SELECT(set) |
-                       PS_UV_HORZ_FILTER_SELECT(set));
-       }
+                       PS_Y_VERT_FILTER_SELECT(0) |
+                       PS_Y_HORZ_FILTER_SELECT(0) |
+                       PS_UV_VERT_FILTER_SELECT(0) |
+                       PS_UV_HORZ_FILTER_SELECT(0));
 
        return PS_FILTER_MEDIUM;
 }
@@ -761,7 +760,7 @@ void skl_pfit_enable(const struct intel_crtc_state *crtc_state)
        id = scaler_state->scaler_id;
 
        ps_ctrl = PS_SCALER_EN | PS_BINDING_PIPE | scaler_state->scalers[id].mode |
-               skl_scaler_get_filter_select(crtc_state->hw.scaling_filter, 0);
+               skl_scaler_get_filter_select(crtc_state->hw.scaling_filter);
 
        trace_intel_pipe_scaler_update_arm(crtc, id, x, y, width, height);
 
@@ -827,7 +826,7 @@ skl_program_plane_scaler(struct intel_dsb *dsb,
        }
 
        ps_ctrl = PS_SCALER_EN | PS_BINDING_PLANE(plane->id) | scaler->mode |
-               skl_scaler_get_filter_select(plane_state->hw.scaling_filter, 0);
+               skl_scaler_get_filter_select(plane_state->hw.scaling_filter);
 
        trace_intel_plane_scaler_update_arm(plane, scaler_id,
                                            crtc_x, crtc_y, crtc_w, crtc_h);