]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: exynos-acpm: register ACPM clocks pdev
authorTudor Ambarus <tudor.ambarus@linaro.org>
Fri, 10 Oct 2025 12:46:33 +0000 (12:46 +0000)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 20 Oct 2025 06:49:50 +0000 (08:49 +0200)
Register by hand a platform device for the ACPM clocks.
The ACPM clocks are not modeled as a DT child of ACPM because:
1/ they don't have their own resources.
2/ they are not a block that can be reused. The clock identifying
   data is reduced (clock ID, clock name and mailbox channel ID)
   and may differ from a SoC to another.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: Peter Griffin <peter.griffin@linaro.org> # on gs101-oriole
Link: https://patch.msgid.link/20251010-acpm-clk-v6-3-321ee8826fd4@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/firmware/samsung/exynos-acpm.c

index 9fa0335ccf5db32892fdf09e8d4b0a885a8f8fb5..0cb269c7046015d4c5fe5731ba0d61d48dcaeee1 100644 (file)
@@ -177,9 +177,11 @@ struct acpm_info {
 /**
  * struct acpm_match_data - of_device_id data.
  * @initdata_base:     offset in SRAM where the channels configuration resides.
+ * @acpm_clk_dev_name: base name for the ACPM clocks device that we're registering.
  */
 struct acpm_match_data {
        loff_t initdata_base;
+       const char *acpm_clk_dev_name;
 };
 
 #define client_to_acpm_chan(c) container_of(c, struct acpm_chan, cl)
@@ -604,9 +606,15 @@ static void acpm_setup_ops(struct acpm_info *acpm)
        pmic_ops->update_reg = acpm_pmic_update_reg;
 }
 
+static void acpm_clk_pdev_unregister(void *data)
+{
+       platform_device_unregister(data);
+}
+
 static int acpm_probe(struct platform_device *pdev)
 {
        const struct acpm_match_data *match_data;
+       struct platform_device *acpm_clk_pdev;
        struct device *dev = &pdev->dev;
        struct device_node *shmem;
        struct acpm_info *acpm;
@@ -647,6 +655,18 @@ static int acpm_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, acpm);
 
+       acpm_clk_pdev = platform_device_register_data(dev,
+                                               match_data->acpm_clk_dev_name,
+                                               PLATFORM_DEVID_NONE, NULL, 0);
+       if (IS_ERR(acpm_clk_pdev))
+               return dev_err_probe(dev, PTR_ERR(acpm_clk_pdev),
+                                    "Failed to register ACPM clocks device.\n");
+
+       ret = devm_add_action_or_reset(dev, acpm_clk_pdev_unregister,
+                                      acpm_clk_pdev);
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to add devm action.\n");
+
        return devm_of_platform_populate(dev);
 }
 
@@ -746,6 +766,7 @@ EXPORT_SYMBOL_GPL(devm_acpm_get_by_node);
 
 static const struct acpm_match_data acpm_gs101 = {
        .initdata_base = ACPM_GS101_INITDATA_BASE,
+       .acpm_clk_dev_name = "gs101-acpm-clk",
 };
 
 static const struct of_device_id acpm_match[] = {