reftable: release name on reftable_reader_new() error

If block_source_read_block() or parse_footer() fail, we leak the "name"
member of struct reftable_reader in reftable_reader_new().  Release it.

Reported by: H Z <shiyuyuranzh@gmail.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/reftable/reader.c b/reftable/reader.c
index 3f2e4b280055ff58178c5b09d7822f47baa5faa1..24bae50ac2fab3a82ca3574af0bd27470edf3837 100644 (file)
--- a/reftable/reader.c
+++ b/reftable/reader.c
@@ -666,6 +666,8 @@ done:
        reftable_block_done(&footer);
        reftable_block_done(&header);
        if (err) {
+               if (r)
+                       reftable_free(r->name);
                reftable_free(r);
                block_source_close(source);
        }