]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mlxsw: spectrum: remove set but not used variable 'autoneg_status'
authorYueHaibing <yuehaibing@huawei.com>
Mon, 25 Feb 2019 02:03:28 +0000 (02:03 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Feb 2019 17:07:35 +0000 (09:07 -0800)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/mellanox/mlxsw/spectrum.c: In function 'mlxsw_sp_port_get_link_ksettings':
drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3062:5: warning:
 variable 'autoneg_status' set but not used [-Wunused-but-set-variable]

It's not used since commit 475b33cb66c9 ("mlxsw: spectrum: Remove unsupported
eth_proto_lp_advertise field in PTYS")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c

index 40177b9834c4723ce223eaf864af71041e21f353..b00f6f74f91a15053e4e77d5a09e950f80dcd4d5 100644 (file)
@@ -3059,7 +3059,6 @@ static int mlxsw_sp_port_get_link_ksettings(struct net_device *dev,
        const struct mlxsw_sp_port_type_speed_ops *ops;
        char ptys_pl[MLXSW_REG_PTYS_LEN];
        u8 connector_type;
-       u8 autoneg_status;
        bool autoneg;
        int err;
 
@@ -3079,8 +3078,6 @@ static int mlxsw_sp_port_get_link_ksettings(struct net_device *dev,
        mlxsw_sp_port_get_link_advertise(mlxsw_sp, eth_proto_admin, autoneg,
                                         cmd);
 
-       autoneg_status = mlxsw_reg_ptys_an_status_get(ptys_pl);
-
        cmd->base.autoneg = autoneg ? AUTONEG_ENABLE : AUTONEG_DISABLE;
        connector_type = mlxsw_reg_ptys_connector_type_get(ptys_pl);
        cmd->base.port = mlxsw_sp_port_connector_port(connector_type);