fs/cifs: Fix resource leak

The -EIO error return path is leaking memory allocated
to page. Fix this by moving the allocation block after
the check of cifs_forced_shutdown.

Addresses-Coverity: ("Resource leak")
Fixes: 087f757b0129 ("cifs: add shutdown support")
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 1cbe7ec7372838783b6e880e11db2b6f32db121e..970fcf2adb08c3ffa7992b6924974e19811ede07 100644 (file)
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -683,12 +683,16 @@ cifs_symlink(struct user_namespace *mnt_userns, struct inode *inode,
        struct tcon_link *tlink;
        struct cifs_tcon *pTcon;
        const char *full_path;
-       void *page = alloc_dentry_path();
+       void *page;
        struct inode *newinode = NULL;
 
        if (unlikely(cifs_forced_shutdown(cifs_sb)))
                return -EIO;
 
+       page = alloc_dentry_path();
+       if (!page)
+               return -ENOMEM;
+
        xid = get_xid();
 
        tlink = cifs_sb_tlink(cifs_sb);