repo: Fix weird argument handling

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/pakfire/repo.c b/src/pakfire/repo.c
index 185bc70e1990dfedd3c8a17f84d16594cd1f537d..ccf3e76c3baa697caf52fb094ce58de0489d8aa4 100644 (file)
--- a/src/pakfire/repo.c
+++ b/src/pakfire/repo.c
@@ -238,10 +238,12 @@ static int pakfire_repo_xfer_create(
        va_list args;
        int r;
 
-       va_start(args, url);
-
        // Create a new transfer
+       va_start(args, url);
        r = pakfire_xfer_create(&x, repo->ctx, url, args);
+       va_end(args);
+
+       // Return on error
        if (r < 0)
                goto ERROR;
 
@@ -269,7 +271,6 @@ ERROR:
                pakfire_mirrorlist_unref(mirrorlist);
        if (x)
                pakfire_xfer_unref(x);
-       va_end(args);
 
        return r;
 }