]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: qla2xxx: Remove qla_tgt_cmd.data_work and qla_tgt_cmd.data_work_free
authorBart Van Assche <bvanassche@acm.org>
Thu, 11 Apr 2019 21:53:23 +0000 (14:53 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Apr 2019 02:04:40 +0000 (22:04 -0400)
The 'data_work' and 'data_work_free' member variables are set but never
used. Hence remove both member variables. See also commit 6bcbb3174caa
("qla2xxx: Fix incorrect tcm_qla2xxx_free_cmd use during TMR ABORT (v2)").

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.h
drivers/scsi/qla2xxx/tcm_qla2xxx.c

index 37e342f12787d0e6e923552699263575f507a237..727dd52963c2d96af75d0e020b172b11e5e6ca18 100644 (file)
@@ -890,8 +890,6 @@ struct qla_tgt_cmd {
        unsigned int cmd_sent_to_fw:1;
        unsigned int cmd_in_wq:1;
        unsigned int aborted:1;
-       unsigned int data_work:1;
-       unsigned int data_work_free:1;
        unsigned int released:1;
 
        struct scatterlist *sg; /* cmd data buffer SG vector */
index 8e192d2cac053c593547eb3ac9922acda32daa65..f98c79ad9352bc0d92224ae2f980b436860ba53a 100644 (file)
@@ -499,9 +499,7 @@ static void tcm_qla2xxx_handle_data_work(struct work_struct *work)
                return;
        }
 
-       cmd->data_work = 1;
        if (cmd->aborted) {
-               cmd->data_work_free = 1;
                spin_unlock_irqrestore(&cmd->cmd_lock, flags);
 
                tcm_qla2xxx_free_cmd(cmd);