]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
Makefile: Fix inclusion of the config-devices.mak.d Kconfig dependencies
authorThomas Huth <thuth@redhat.com>
Fri, 10 May 2019 08:11:59 +0000 (10:11 +0200)
committerThomas Huth <thuth@redhat.com>
Mon, 13 May 2019 07:36:31 +0000 (09:36 +0200)
The Makefile tries to include device Kconfig dependencies via

 -include $(SUBDIR_DEVICES_MAK_DEP)

and thus expects files that match *-softmmu/config-devices.mak.d ...
however, the minikconf script currently generates files a la
"*-softmmu-config.devices.mak.d" instead, so the dependency files
simply got ignored so far. For example, after a "touch hw/arm/Kconfig",
the arm-softmmu/config-devices.mak file is currently not re-generated.
Fix it by putting the dependency files in the *-softmmu folders now.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Makefile
configure
docs/devel/kconfig.rst

index 4a8ae0ef95d566cfb2da373631fd1beab07c9bd3..66d5c65156e6e90f58466ccaa90055bdbfa3225d 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -350,7 +350,7 @@ endif
 # This has to be kept in sync with Kconfig.host.
 MINIKCONF_ARGS = \
     $(CONFIG_MINIKCONF_MODE) \
-    $@ $*-config.devices.mak.d $< $(MINIKCONF_INPUTS) \
+    $@ $*/config-devices.mak.d $< $(MINIKCONF_INPUTS) \
     CONFIG_KVM=$(CONFIG_KVM) \
     CONFIG_SPICE=$(CONFIG_SPICE) \
     CONFIG_IVSHMEM=$(CONFIG_IVSHMEM) \
index 63f312bd1f932769d3a8b061d0a92b978b781bfd..8999698bc2793cbfdc05a215ae696be5dbb2d588 100755 (executable)
--- a/configure
+++ b/configure
@@ -1832,7 +1832,7 @@ exit 0
 fi
 
 # Remove old dependency files to make sure that they get properly regenerated
-rm -f *-config-devices.mak.d
+rm -f */config-devices.mak.d
 
 if test -z "$python"
 then
index cce146f87d7823b9324bc56182bdeca5f0016437..d6f8eb097757cd7ae2388942907b7376550993c8 100644 (file)
@@ -299,7 +299,7 @@ and also listed as follows in the top-level Makefile's ``MINIKCONF_ARGS``
 variable::
 
     MINIKCONF_ARGS = \
-      $@ $*-config.devices.mak.d $< $(MINIKCONF_INPUTS) \
+      $@ $*/config-devices.mak.d $< $(MINIKCONF_INPUTS) \
       CONFIG_KVM=$(CONFIG_KVM) \
       CONFIG_SPICE=$(CONFIG_SPICE) \
       CONFIG_TPM=$(CONFIG_TPM) \