]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
HID: intel-thc-hid: intel-thc: make read-only arrays static const
authorColin Ian King <colin.i.king@gmail.com>
Wed, 2 Apr 2025 11:21:29 +0000 (12:21 +0100)
committerJiri Kosina <jkosina@suse.com>
Thu, 24 Apr 2025 10:14:33 +0000 (12:14 +0200)
Don't populate the read-only arrays frequency and frequency_div on
the stack at run time, instead make them static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Even Xu <even.xu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c

index 4fc78b5a04b5fbf6465bc5e672c6a87cef470010..c105df7f6c8733f9c85fda6519d67e0d586b0b82 100644 (file)
@@ -1121,7 +1121,7 @@ EXPORT_SYMBOL_NS_GPL(thc_port_select, "INTEL_THC");
 
 static u8 thc_get_spi_freq_div_val(struct thc_device *dev, u32 spi_freq_val)
 {
-       int frequency[] = {
+       static const int frequency[] = {
                THC_SPI_FREQUENCY_7M,
                THC_SPI_FREQUENCY_15M,
                THC_SPI_FREQUENCY_17M,
@@ -1130,7 +1130,7 @@ static u8 thc_get_spi_freq_div_val(struct thc_device *dev, u32 spi_freq_val)
                THC_SPI_FREQUENCY_31M,
                THC_SPI_FREQUENCY_41M,
        };
-       u8 frequency_div[] = {
+       static const u8 frequency_div[] = {
                THC_SPI_FRQ_DIV_2,
                THC_SPI_FRQ_DIV_1,
                THC_SPI_FRQ_DIV_7,