]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
HID: pidff: Rename two functions to align them with naming convention
authorTomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
Tue, 25 Feb 2025 22:30:00 +0000 (23:30 +0100)
committerJiri Kosina <jkosina@suse.com>
Tue, 4 Mar 2025 20:42:44 +0000 (21:42 +0100)
Driver uses "set" everywhere to indicate setting report values and
requesting HID_REQ_SET_REPORT

Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/usbhid/hid-pidff.c

index 6f6c47bd57eaaf3cf7e73ee72b0688fe11e7c8fc..ffecc712be003580871265fb482c0d1ed5e412d7 100644 (file)
@@ -552,7 +552,7 @@ static void pidff_set_gain_report(struct pidff_device *pidff, u16 gain)
 /*
  * Clear device control report
  */
-static void pidff_send_device_control(struct pidff_device *pidff, int field)
+static void pidff_set_device_control(struct pidff_device *pidff, int field)
 {
        int i, tmp;
        int field_index = pidff->control_id[field];
@@ -578,10 +578,10 @@ static void pidff_send_device_control(struct pidff_device *pidff, int field)
 /*
  * Modify actuators state
  */
-static void pidff_modify_actuators_state(struct pidff_device *pidff, bool enable)
+static void pidff_set_actuators(struct pidff_device *pidff, bool enable)
 {
        hid_dbg(pidff->hid, "%s actuators\n", enable ? "Enable" : "Disable");
-       pidff_send_device_control(pidff,
+       pidff_set_device_control(pidff,
                enable ? PID_ENABLE_ACTUATORS : PID_DISABLE_ACTUATORS);
 }
 
@@ -591,12 +591,12 @@ static void pidff_modify_actuators_state(struct pidff_device *pidff, bool enable
 static void pidff_reset(struct pidff_device *pidff)
 {
        /* We reset twice as sometimes hid_wait_io isn't waiting long enough */
-       pidff_send_device_control(pidff, PID_RESET);
-       pidff_send_device_control(pidff, PID_RESET);
+       pidff_set_device_control(pidff, PID_RESET);
+       pidff_set_device_control(pidff, PID_RESET);
        pidff->effect_count = 0;
 
-       pidff_send_device_control(pidff, PID_STOP_ALL_EFFECTS);
-       pidff_modify_actuators_state(pidff, 1);
+       pidff_set_device_control(pidff, PID_STOP_ALL_EFFECTS);
+       pidff_set_actuators(pidff, 1);
 }
 
 /*