]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ipv6: Use nlmsg_payload in route file
authorBreno Leitao <leitao@debian.org>
Tue, 15 Apr 2025 19:28:54 +0000 (12:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 01:33:02 +0000 (18:33 -0700)
Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250415-nlmsg_v2-v1-3-a1c75d493fd7@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/route.c

index 210b84cecc2427a3dc2df33b967b141e01b60889..e2c6c0b0684b23680d87900d6190b40a0df9f0a9 100644 (file)
@@ -6029,7 +6029,8 @@ static int inet6_rtm_valid_getroute_req(struct sk_buff *skb,
        struct rtmsg *rtm;
        int i, err;
 
-       if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*rtm))) {
+       rtm = nlmsg_payload(nlh, sizeof(*rtm));
+       if (!rtm) {
                NL_SET_ERR_MSG_MOD(extack,
                                   "Invalid header for get route request");
                return -EINVAL;
@@ -6039,7 +6040,6 @@ static int inet6_rtm_valid_getroute_req(struct sk_buff *skb,
                return nlmsg_parse_deprecated(nlh, sizeof(*rtm), tb, RTA_MAX,
                                              rtm_ipv6_policy, extack);
 
-       rtm = nlmsg_data(nlh);
        if ((rtm->rtm_src_len && rtm->rtm_src_len != 128) ||
            (rtm->rtm_dst_len && rtm->rtm_dst_len != 128) ||
            rtm->rtm_table || rtm->rtm_protocol || rtm->rtm_scope ||