5.4-stable patches

added patches:
	ata-define-ac_err_ok.patch
	ata-make-qc_prep-return-ata_completion_errors.patch
	ata-sata_mv-avoid-trigerrable-bug_on.patch

diff --git a/queue-5.4/ata-define-ac_err_ok.patch b/queue-5.4/ata-define-ac_err_ok.patch
new file mode 100644 (file)
index 0000000..12d180e
--- /dev/null
+++ b/queue-5.4/ata-define-ac_err_ok.patch
@@ -0,0 +1,32 @@
+From 25937580a5065d6fbd92d9c8ebd47145ad80052e Mon Sep 17 00:00:00 2001
+From: Jiri Slaby <jslaby@suse.cz>
+Date: Thu, 31 Oct 2019 10:59:44 +0100
+Subject: ata: define AC_ERR_OK
+
+From: Jiri Slaby <jslaby@suse.cz>
+
+commit 25937580a5065d6fbd92d9c8ebd47145ad80052e upstream.
+
+Since we will return enum ata_completion_errors from qc_prep in the next
+patch, let's define AC_ERR_OK to mark the OK status.
+
+Signed-off-by: Jiri Slaby <jslaby@suse.cz>
+Cc: Jens Axboe <axboe@kernel.dk>
+Cc: linux-ide@vger.kernel.org
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ include/linux/libata.h |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/include/linux/libata.h
++++ b/include/linux/libata.h
+@@ -486,6 +486,7 @@ enum hsm_task_states {
+ };
+ 
+ enum ata_completion_errors {
++      AC_ERR_OK               = 0,        /* no error */
+       AC_ERR_DEV              = (1 << 0), /* device reported error */
+       AC_ERR_HSM              = (1 << 1), /* host state machine violation */
+       AC_ERR_TIMEOUT          = (1 << 2), /* timeout */

diff --git a/queue-5.4/ata-make-qc_prep-return-ata_completion_errors.patch b/queue-5.4/ata-make-qc_prep-return-ata_completion_errors.patch
new file mode 100644 (file)
index 0000000..1003b9a
--- /dev/null
+++ b/queue-5.4/ata-make-qc_prep-return-ata_completion_errors.patch
@@ -0,0 +1,676 @@
+From 95364f36701e62dd50eee91e1303187fd1a9f567 Mon Sep 17 00:00:00 2001
+From: Jiri Slaby <jslaby@suse.cz>
+Date: Thu, 31 Oct 2019 10:59:45 +0100
+Subject: ata: make qc_prep return ata_completion_errors
+
+From: Jiri Slaby <jslaby@suse.cz>
+
+commit 95364f36701e62dd50eee91e1303187fd1a9f567 upstream.
+
+In case a driver wants to return an error from qc_prep, return enum
+ata_completion_errors. sata_mv is one of those drivers -- see the next
+patch. Other drivers return the newly defined AC_ERR_OK.
+
+[v2] use enum ata_completion_errors and AC_ERR_OK.
+
+Signed-off-by: Jiri Slaby <jslaby@suse.cz>
+Cc: Jens Axboe <axboe@kernel.dk>
+Cc: linux-ide@vger.kernel.org
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ Documentation/driver-api/libata.rst |    2 +-
+ drivers/ata/acard-ahci.c            |    6 ++++--
+ drivers/ata/libahci.c               |    6 ++++--
+ drivers/ata/libata-core.c           |    9 +++++++--
+ drivers/ata/libata-sff.c            |   12 ++++++++----
+ drivers/ata/pata_macio.c            |    6 ++++--
+ drivers/ata/pata_pxa.c              |    8 +++++---
+ drivers/ata/pdc_adma.c              |    7 ++++---
+ drivers/ata/sata_fsl.c              |    4 +++-
+ drivers/ata/sata_inic162x.c         |    4 +++-
+ drivers/ata/sata_mv.c               |   26 +++++++++++++++-----------
+ drivers/ata/sata_nv.c               |   18 +++++++++++-------
+ drivers/ata/sata_promise.c          |    6 ++++--
+ drivers/ata/sata_qstor.c            |    8 +++++---
+ drivers/ata/sata_rcar.c             |    6 ++++--
+ drivers/ata/sata_sil.c              |    8 +++++---
+ drivers/ata/sata_sil24.c            |    6 ++++--
+ drivers/ata/sata_sx4.c              |    6 ++++--
+ include/linux/libata.h              |   12 ++++++------
+ 19 files changed, 101 insertions(+), 59 deletions(-)
+
+--- a/Documentation/driver-api/libata.rst
++++ b/Documentation/driver-api/libata.rst
+@@ -250,7 +250,7 @@ High-level taskfile hooks
+ 
+ ::
+ 
+-    void (*qc_prep) (struct ata_queued_cmd *qc);
++    enum ata_completion_errors (*qc_prep) (struct ata_queued_cmd *qc);
+     int (*qc_issue) (struct ata_queued_cmd *qc);
+ 
+ 
+--- a/drivers/ata/acard-ahci.c
++++ b/drivers/ata/acard-ahci.c
+@@ -56,7 +56,7 @@ struct acard_sg {
+       __le32                  size;    /* bit 31 (EOT) max==0x10000 (64k) */
+ };
+ 
+-static void acard_ahci_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors acard_ahci_qc_prep(struct ata_queued_cmd *qc);
+ static bool acard_ahci_qc_fill_rtf(struct ata_queued_cmd *qc);
+ static int acard_ahci_port_start(struct ata_port *ap);
+ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
+@@ -210,7 +210,7 @@ static unsigned int acard_ahci_fill_sg(s
+       return si;
+ }
+ 
+-static void acard_ahci_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors acard_ahci_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct ata_port *ap = qc->ap;
+       struct ahci_port_priv *pp = ap->private_data;
+@@ -248,6 +248,8 @@ static void acard_ahci_qc_prep(struct at
+               opts |= AHCI_CMD_ATAPI | AHCI_CMD_PREFETCH;
+ 
+       ahci_fill_cmd_slot(pp, qc->hw_tag, opts);
++
++      return AC_ERR_OK;
+ }
+ 
+ static bool acard_ahci_qc_fill_rtf(struct ata_queued_cmd *qc)
+--- a/drivers/ata/libahci.c
++++ b/drivers/ata/libahci.c
+@@ -57,7 +57,7 @@ static int ahci_scr_write(struct ata_lin
+ static bool ahci_qc_fill_rtf(struct ata_queued_cmd *qc);
+ static int ahci_port_start(struct ata_port *ap);
+ static void ahci_port_stop(struct ata_port *ap);
+-static void ahci_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors ahci_qc_prep(struct ata_queued_cmd *qc);
+ static int ahci_pmp_qc_defer(struct ata_queued_cmd *qc);
+ static void ahci_freeze(struct ata_port *ap);
+ static void ahci_thaw(struct ata_port *ap);
+@@ -1624,7 +1624,7 @@ static int ahci_pmp_qc_defer(struct ata_
+               return sata_pmp_qc_defer_cmd_switch(qc);
+ }
+ 
+-static void ahci_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors ahci_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct ata_port *ap = qc->ap;
+       struct ahci_port_priv *pp = ap->private_data;
+@@ -1660,6 +1660,8 @@ static void ahci_qc_prep(struct ata_queu
+               opts |= AHCI_CMD_ATAPI | AHCI_CMD_PREFETCH;
+ 
+       ahci_fill_cmd_slot(pp, qc->hw_tag, opts);
++
++      return AC_ERR_OK;
+ }
+ 
+ static void ahci_fbs_dec_intr(struct ata_port *ap)
+--- a/drivers/ata/libata-core.c
++++ b/drivers/ata/libata-core.c
+@@ -4978,7 +4978,10 @@ int ata_std_qc_defer(struct ata_queued_c
+       return ATA_DEFER_LINK;
+ }
+ 
+-void ata_noop_qc_prep(struct ata_queued_cmd *qc) { }
++enum ata_completion_errors ata_noop_qc_prep(struct ata_queued_cmd *qc)
++{
++      return AC_ERR_OK;
++}
+ 
+ /**
+  *    ata_sg_init - Associate command with scatter-gather table.
+@@ -5465,7 +5468,9 @@ void ata_qc_issue(struct ata_queued_cmd
+               return;
+       }
+ 
+-      ap->ops->qc_prep(qc);
++      qc->err_mask |= ap->ops->qc_prep(qc);
++      if (unlikely(qc->err_mask))
++              goto err;
+       trace_ata_qc_issue(qc);
+       qc->err_mask |= ap->ops->qc_issue(qc);
+       if (unlikely(qc->err_mask))
+--- a/drivers/ata/libata-sff.c
++++ b/drivers/ata/libata-sff.c
+@@ -2679,12 +2679,14 @@ static void ata_bmdma_fill_sg_dumb(struc
+  *    LOCKING:
+  *    spin_lock_irqsave(host lock)
+  */
+-void ata_bmdma_qc_prep(struct ata_queued_cmd *qc)
++enum ata_completion_errors ata_bmdma_qc_prep(struct ata_queued_cmd *qc)
+ {
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       ata_bmdma_fill_sg(qc);
++
++      return AC_ERR_OK;
+ }
+ EXPORT_SYMBOL_GPL(ata_bmdma_qc_prep);
+ 
+@@ -2697,12 +2699,14 @@ EXPORT_SYMBOL_GPL(ata_bmdma_qc_prep);
+  *    LOCKING:
+  *    spin_lock_irqsave(host lock)
+  */
+-void ata_bmdma_dumb_qc_prep(struct ata_queued_cmd *qc)
++enum ata_completion_errors ata_bmdma_dumb_qc_prep(struct ata_queued_cmd *qc)
+ {
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       ata_bmdma_fill_sg_dumb(qc);
++
++      return AC_ERR_OK;
+ }
+ EXPORT_SYMBOL_GPL(ata_bmdma_dumb_qc_prep);
+ 
+--- a/drivers/ata/pata_macio.c
++++ b/drivers/ata/pata_macio.c
+@@ -510,7 +510,7 @@ static int pata_macio_cable_detect(struc
+       return ATA_CBL_PATA40;
+ }
+ 
+-static void pata_macio_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors pata_macio_qc_prep(struct ata_queued_cmd *qc)
+ {
+       unsigned int write = (qc->tf.flags & ATA_TFLAG_WRITE);
+       struct ata_port *ap = qc->ap;
+@@ -523,7 +523,7 @@ static void pata_macio_qc_prep(struct at
+                  __func__, qc, qc->flags, write, qc->dev->devno);
+ 
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       table = (struct dbdma_cmd *) priv->dma_table_cpu;
+ 
+@@ -568,6 +568,8 @@ static void pata_macio_qc_prep(struct at
+       table->command = cpu_to_le16(DBDMA_STOP);
+ 
+       dev_dbgdma(priv->dev, "%s: %d DMA list entries\n", __func__, pi);
++
++      return AC_ERR_OK;
+ }
+ 
+ 
+--- a/drivers/ata/pata_pxa.c
++++ b/drivers/ata/pata_pxa.c
+@@ -44,25 +44,27 @@ static void pxa_ata_dma_irq(void *d)
+ /*
+  * Prepare taskfile for submission.
+  */
+-static void pxa_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors pxa_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct pata_pxa_data *pd = qc->ap->private_data;
+       struct dma_async_tx_descriptor *tx;
+       enum dma_transfer_direction dir;
+ 
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       dir = (qc->dma_dir == DMA_TO_DEVICE ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM);
+       tx = dmaengine_prep_slave_sg(pd->dma_chan, qc->sg, qc->n_elem, dir,
+                                    DMA_PREP_INTERRUPT);
+       if (!tx) {
+               ata_dev_err(qc->dev, "prep_slave_sg() failed\n");
+-              return;
++              return AC_ERR_OK;
+       }
+       tx->callback = pxa_ata_dma_irq;
+       tx->callback_param = pd;
+       pd->dma_cookie = dmaengine_submit(tx);
++
++      return AC_ERR_OK;
+ }
+ 
+ /*
+--- a/drivers/ata/pdc_adma.c
++++ b/drivers/ata/pdc_adma.c
+@@ -116,7 +116,7 @@ static int adma_ata_init_one(struct pci_
+                               const struct pci_device_id *ent);
+ static int adma_port_start(struct ata_port *ap);
+ static void adma_port_stop(struct ata_port *ap);
+-static void adma_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors adma_qc_prep(struct ata_queued_cmd *qc);
+ static unsigned int adma_qc_issue(struct ata_queued_cmd *qc);
+ static int adma_check_atapi_dma(struct ata_queued_cmd *qc);
+ static void adma_freeze(struct ata_port *ap);
+@@ -295,7 +295,7 @@ static int adma_fill_sg(struct ata_queue
+       return i;
+ }
+ 
+-static void adma_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors adma_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct adma_port_priv *pp = qc->ap->private_data;
+       u8  *buf = pp->pkt;
+@@ -306,7 +306,7 @@ static void adma_qc_prep(struct ata_queu
+ 
+       adma_enter_reg_mode(qc->ap);
+       if (qc->tf.protocol != ATA_PROT_DMA)
+-              return;
++              return AC_ERR_OK;
+ 
+       buf[i++] = 0;   /* Response flags */
+       buf[i++] = 0;   /* reserved */
+@@ -371,6 +371,7 @@ static void adma_qc_prep(struct ata_queu
+                       printk("%s\n", obuf);
+       }
+ #endif
++      return AC_ERR_OK;
+ }
+ 
+ static inline void adma_packet_start(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_fsl.c
++++ b/drivers/ata/sata_fsl.c
+@@ -502,7 +502,7 @@ static unsigned int sata_fsl_fill_sg(str
+       return num_prde;
+ }
+ 
+-static void sata_fsl_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors sata_fsl_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct ata_port *ap = qc->ap;
+       struct sata_fsl_port_priv *pp = ap->private_data;
+@@ -548,6 +548,8 @@ static void sata_fsl_qc_prep(struct ata_
+ 
+       VPRINTK("SATA FSL : xx_qc_prep, di = 0x%x, ttl = %d, num_prde = %d\n",
+               desc_info, ttl_dwords, num_prde);
++
++      return AC_ERR_OK;
+ }
+ 
+ static unsigned int sata_fsl_qc_issue(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_inic162x.c
++++ b/drivers/ata/sata_inic162x.c
+@@ -478,7 +478,7 @@ static void inic_fill_sg(struct inic_prd
+       prd[-1].flags |= PRD_END;
+ }
+ 
+-static void inic_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors inic_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct inic_port_priv *pp = qc->ap->private_data;
+       struct inic_pkt *pkt = pp->pkt;
+@@ -538,6 +538,8 @@ static void inic_qc_prep(struct ata_queu
+               inic_fill_sg(prd, qc);
+ 
+       pp->cpb_tbl[0] = pp->pkt_dma;
++
++      return AC_ERR_OK;
+ }
+ 
+ static unsigned int inic_qc_issue(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_mv.c
++++ b/drivers/ata/sata_mv.c
+@@ -592,8 +592,8 @@ static int mv5_scr_write(struct ata_link
+ static int mv_port_start(struct ata_port *ap);
+ static void mv_port_stop(struct ata_port *ap);
+ static int mv_qc_defer(struct ata_queued_cmd *qc);
+-static void mv_qc_prep(struct ata_queued_cmd *qc);
+-static void mv_qc_prep_iie(struct ata_queued_cmd *qc);
++static enum ata_completion_errors mv_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors mv_qc_prep_iie(struct ata_queued_cmd *qc);
+ static unsigned int mv_qc_issue(struct ata_queued_cmd *qc);
+ static int mv_hardreset(struct ata_link *link, unsigned int *class,
+                       unsigned long deadline);
+@@ -2031,7 +2031,7 @@ static void mv_rw_multi_errata_sata24(st
+  *      LOCKING:
+  *      Inherited from caller.
+  */
+-static void mv_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors mv_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct ata_port *ap = qc->ap;
+       struct mv_port_priv *pp = ap->private_data;
+@@ -2043,15 +2043,15 @@ static void mv_qc_prep(struct ata_queued
+       switch (tf->protocol) {
+       case ATA_PROT_DMA:
+               if (tf->command == ATA_CMD_DSM)
+-                      return;
++                      return AC_ERR_OK;
+               /* fall-thru */
+       case ATA_PROT_NCQ:
+               break;  /* continue below */
+       case ATA_PROT_PIO:
+               mv_rw_multi_errata_sata24(qc);
+-              return;
++              return AC_ERR_OK;
+       default:
+-              return;
++              return AC_ERR_OK;
+       }
+ 
+       /* Fill in command request block
+@@ -2116,8 +2116,10 @@ static void mv_qc_prep(struct ata_queued
+       mv_crqb_pack_cmd(cw++, tf->command, ATA_REG_CMD, 1);    /* last */
+ 
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+       mv_fill_sg(qc);
++
++      return AC_ERR_OK;
+ }
+ 
+ /**
+@@ -2132,7 +2134,7 @@ static void mv_qc_prep(struct ata_queued
+  *      LOCKING:
+  *      Inherited from caller.
+  */
+-static void mv_qc_prep_iie(struct ata_queued_cmd *qc)
++static enum ata_completion_errors mv_qc_prep_iie(struct ata_queued_cmd *qc)
+ {
+       struct ata_port *ap = qc->ap;
+       struct mv_port_priv *pp = ap->private_data;
+@@ -2143,9 +2145,9 @@ static void mv_qc_prep_iie(struct ata_qu
+ 
+       if ((tf->protocol != ATA_PROT_DMA) &&
+           (tf->protocol != ATA_PROT_NCQ))
+-              return;
++              return AC_ERR_OK;
+       if (tf->command == ATA_CMD_DSM)
+-              return;  /* use bmdma for this */
++              return AC_ERR_OK;  /* use bmdma for this */
+ 
+       /* Fill in Gen IIE command request block */
+       if (!(tf->flags & ATA_TFLAG_WRITE))
+@@ -2186,8 +2188,10 @@ static void mv_qc_prep_iie(struct ata_qu
+               );
+ 
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+       mv_fill_sg(qc);
++
++      return AC_ERR_OK;
+ }
+ 
+ /**
+--- a/drivers/ata/sata_nv.c
++++ b/drivers/ata/sata_nv.c
+@@ -297,7 +297,7 @@ static void nv_ck804_freeze(struct ata_p
+ static void nv_ck804_thaw(struct ata_port *ap);
+ static int nv_adma_slave_config(struct scsi_device *sdev);
+ static int nv_adma_check_atapi_dma(struct ata_queued_cmd *qc);
+-static void nv_adma_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors nv_adma_qc_prep(struct ata_queued_cmd *qc);
+ static unsigned int nv_adma_qc_issue(struct ata_queued_cmd *qc);
+ static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance);
+ static void nv_adma_irq_clear(struct ata_port *ap);
+@@ -319,7 +319,7 @@ static void nv_mcp55_freeze(struct ata_p
+ static void nv_swncq_error_handler(struct ata_port *ap);
+ static int nv_swncq_slave_config(struct scsi_device *sdev);
+ static int nv_swncq_port_start(struct ata_port *ap);
+-static void nv_swncq_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors nv_swncq_qc_prep(struct ata_queued_cmd *qc);
+ static void nv_swncq_fill_sg(struct ata_queued_cmd *qc);
+ static unsigned int nv_swncq_qc_issue(struct ata_queued_cmd *qc);
+ static void nv_swncq_irq_clear(struct ata_port *ap, u16 fis);
+@@ -1344,7 +1344,7 @@ static int nv_adma_use_reg_mode(struct a
+       return 1;
+ }
+ 
+-static void nv_adma_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors nv_adma_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct nv_adma_port_priv *pp = qc->ap->private_data;
+       struct nv_adma_cpb *cpb = &pp->cpb[qc->hw_tag];
+@@ -1356,7 +1356,7 @@ static void nv_adma_qc_prep(struct ata_q
+                       (qc->flags & ATA_QCFLAG_DMAMAP));
+               nv_adma_register_mode(qc->ap);
+               ata_bmdma_qc_prep(qc);
+-              return;
++              return AC_ERR_OK;
+       }
+ 
+       cpb->resp_flags = NV_CPB_RESP_DONE;
+@@ -1388,6 +1388,8 @@ static void nv_adma_qc_prep(struct ata_q
+       cpb->ctl_flags = ctl_flags;
+       wmb();
+       cpb->resp_flags = 0;
++
++      return AC_ERR_OK;
+ }
+ 
+ static unsigned int nv_adma_qc_issue(struct ata_queued_cmd *qc)
+@@ -1950,17 +1952,19 @@ static int nv_swncq_port_start(struct at
+       return 0;
+ }
+ 
+-static void nv_swncq_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors nv_swncq_qc_prep(struct ata_queued_cmd *qc)
+ {
+       if (qc->tf.protocol != ATA_PROT_NCQ) {
+               ata_bmdma_qc_prep(qc);
+-              return;
++              return AC_ERR_OK;
+       }
+ 
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       nv_swncq_fill_sg(qc);
++
++      return AC_ERR_OK;
+ }
+ 
+ static void nv_swncq_fill_sg(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_promise.c
++++ b/drivers/ata/sata_promise.c
+@@ -139,7 +139,7 @@ static int pdc_sata_scr_write(struct ata
+ static int pdc_ata_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
+ static int pdc_common_port_start(struct ata_port *ap);
+ static int pdc_sata_port_start(struct ata_port *ap);
+-static void pdc_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors pdc_qc_prep(struct ata_queued_cmd *qc);
+ static void pdc_tf_load_mmio(struct ata_port *ap, const struct ata_taskfile *tf);
+ static void pdc_exec_command_mmio(struct ata_port *ap, const struct ata_taskfile *tf);
+ static int pdc_check_atapi_dma(struct ata_queued_cmd *qc);
+@@ -633,7 +633,7 @@ static void pdc_fill_sg(struct ata_queue
+       prd[idx - 1].flags_len |= cpu_to_le32(ATA_PRD_EOT);
+ }
+ 
+-static void pdc_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors pdc_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct pdc_port_priv *pp = qc->ap->private_data;
+       unsigned int i;
+@@ -665,6 +665,8 @@ static void pdc_qc_prep(struct ata_queue
+       default:
+               break;
+       }
++
++      return AC_ERR_OK;
+ }
+ 
+ static int pdc_is_sataii_tx4(unsigned long flags)
+--- a/drivers/ata/sata_qstor.c
++++ b/drivers/ata/sata_qstor.c
+@@ -100,7 +100,7 @@ static int qs_scr_write(struct ata_link
+ static int qs_ata_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
+ static int qs_port_start(struct ata_port *ap);
+ static void qs_host_stop(struct ata_host *host);
+-static void qs_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors qs_qc_prep(struct ata_queued_cmd *qc);
+ static unsigned int qs_qc_issue(struct ata_queued_cmd *qc);
+ static int qs_check_atapi_dma(struct ata_queued_cmd *qc);
+ static void qs_freeze(struct ata_port *ap);
+@@ -260,7 +260,7 @@ static unsigned int qs_fill_sg(struct at
+       return si;
+ }
+ 
+-static void qs_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors qs_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct qs_port_priv *pp = qc->ap->private_data;
+       u8 dflags = QS_DF_PORD, *buf = pp->pkt;
+@@ -272,7 +272,7 @@ static void qs_qc_prep(struct ata_queued
+ 
+       qs_enter_reg_mode(qc->ap);
+       if (qc->tf.protocol != ATA_PROT_DMA)
+-              return;
++              return AC_ERR_OK;
+ 
+       nelem = qs_fill_sg(qc);
+ 
+@@ -295,6 +295,8 @@ static void qs_qc_prep(struct ata_queued
+ 
+       /* frame information structure (FIS) */
+       ata_tf_to_fis(&qc->tf, 0, 1, &buf[32]);
++
++      return AC_ERR_OK;
+ }
+ 
+ static inline void qs_packet_start(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_rcar.c
++++ b/drivers/ata/sata_rcar.c
+@@ -550,12 +550,14 @@ static void sata_rcar_bmdma_fill_sg(stru
+       prd[si - 1].addr |= cpu_to_le32(SATA_RCAR_DTEND);
+ }
+ 
+-static void sata_rcar_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors sata_rcar_qc_prep(struct ata_queued_cmd *qc)
+ {
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       sata_rcar_bmdma_fill_sg(qc);
++
++      return AC_ERR_OK;
+ }
+ 
+ static void sata_rcar_bmdma_setup(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_sil.c
++++ b/drivers/ata/sata_sil.c
+@@ -103,7 +103,7 @@ static void sil_dev_config(struct ata_de
+ static int sil_scr_read(struct ata_link *link, unsigned int sc_reg, u32 *val);
+ static int sil_scr_write(struct ata_link *link, unsigned int sc_reg, u32 val);
+ static int sil_set_mode(struct ata_link *link, struct ata_device **r_failed);
+-static void sil_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors sil_qc_prep(struct ata_queued_cmd *qc);
+ static void sil_bmdma_setup(struct ata_queued_cmd *qc);
+ static void sil_bmdma_start(struct ata_queued_cmd *qc);
+ static void sil_bmdma_stop(struct ata_queued_cmd *qc);
+@@ -317,12 +317,14 @@ static void sil_fill_sg(struct ata_queue
+               last_prd->flags_len |= cpu_to_le32(ATA_PRD_EOT);
+ }
+ 
+-static void sil_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors sil_qc_prep(struct ata_queued_cmd *qc)
+ {
+       if (!(qc->flags & ATA_QCFLAG_DMAMAP))
+-              return;
++              return AC_ERR_OK;
+ 
+       sil_fill_sg(qc);
++
++      return AC_ERR_OK;
+ }
+ 
+ static unsigned char sil_get_device_cache_line(struct pci_dev *pdev)
+--- a/drivers/ata/sata_sil24.c
++++ b/drivers/ata/sata_sil24.c
+@@ -326,7 +326,7 @@ static void sil24_dev_config(struct ata_
+ static int sil24_scr_read(struct ata_link *link, unsigned sc_reg, u32 *val);
+ static int sil24_scr_write(struct ata_link *link, unsigned sc_reg, u32 val);
+ static int sil24_qc_defer(struct ata_queued_cmd *qc);
+-static void sil24_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors sil24_qc_prep(struct ata_queued_cmd *qc);
+ static unsigned int sil24_qc_issue(struct ata_queued_cmd *qc);
+ static bool sil24_qc_fill_rtf(struct ata_queued_cmd *qc);
+ static void sil24_pmp_attach(struct ata_port *ap);
+@@ -830,7 +830,7 @@ static int sil24_qc_defer(struct ata_que
+       return ata_std_qc_defer(qc);
+ }
+ 
+-static void sil24_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors sil24_qc_prep(struct ata_queued_cmd *qc)
+ {
+       struct ata_port *ap = qc->ap;
+       struct sil24_port_priv *pp = ap->private_data;
+@@ -874,6 +874,8 @@ static void sil24_qc_prep(struct ata_que
+ 
+       if (qc->flags & ATA_QCFLAG_DMAMAP)
+               sil24_fill_sg(qc, sge);
++
++      return AC_ERR_OK;
+ }
+ 
+ static unsigned int sil24_qc_issue(struct ata_queued_cmd *qc)
+--- a/drivers/ata/sata_sx4.c
++++ b/drivers/ata/sata_sx4.c
+@@ -202,7 +202,7 @@ static void pdc_error_handler(struct ata
+ static void pdc_freeze(struct ata_port *ap);
+ static void pdc_thaw(struct ata_port *ap);
+ static int pdc_port_start(struct ata_port *ap);
+-static void pdc20621_qc_prep(struct ata_queued_cmd *qc);
++static enum ata_completion_errors pdc20621_qc_prep(struct ata_queued_cmd *qc);
+ static void pdc_tf_load_mmio(struct ata_port *ap, const struct ata_taskfile *tf);
+ static void pdc_exec_command_mmio(struct ata_port *ap, const struct ata_taskfile *tf);
+ static unsigned int pdc20621_dimm_init(struct ata_host *host);
+@@ -530,7 +530,7 @@ static void pdc20621_nodata_prep(struct
+       VPRINTK("ata pkt buf ofs %u, mmio copied\n", i);
+ }
+ 
+-static void pdc20621_qc_prep(struct ata_queued_cmd *qc)
++static enum ata_completion_errors pdc20621_qc_prep(struct ata_queued_cmd *qc)
+ {
+       switch (qc->tf.protocol) {
+       case ATA_PROT_DMA:
+@@ -542,6 +542,8 @@ static void pdc20621_qc_prep(struct ata_
+       default:
+               break;
+       }
++
++      return AC_ERR_OK;
+ }
+ 
+ static void __pdc20621_push_hdma(struct ata_queued_cmd *qc,
+--- a/include/linux/libata.h
++++ b/include/linux/libata.h
+@@ -896,9 +896,9 @@ struct ata_port_operations {
+       /*
+        * Command execution
+        */
+-      int  (*qc_defer)(struct ata_queued_cmd *qc);
+-      int  (*check_atapi_dma)(struct ata_queued_cmd *qc);
+-      void (*qc_prep)(struct ata_queued_cmd *qc);
++      int (*qc_defer)(struct ata_queued_cmd *qc);
++      int (*check_atapi_dma)(struct ata_queued_cmd *qc);
++      enum ata_completion_errors (*qc_prep)(struct ata_queued_cmd *qc);
+       unsigned int (*qc_issue)(struct ata_queued_cmd *qc);
+       bool (*qc_fill_rtf)(struct ata_queued_cmd *qc);
+ 
+@@ -1166,7 +1166,7 @@ extern int ata_xfer_mode2shift(unsigned
+ extern const char *ata_mode_string(unsigned long xfer_mask);
+ extern unsigned long ata_id_xfermask(const u16 *id);
+ extern int ata_std_qc_defer(struct ata_queued_cmd *qc);
+-extern void ata_noop_qc_prep(struct ata_queued_cmd *qc);
++extern enum ata_completion_errors ata_noop_qc_prep(struct ata_queued_cmd *qc);
+ extern void ata_sg_init(struct ata_queued_cmd *qc, struct scatterlist *sg,
+                unsigned int n_elem);
+ extern unsigned int ata_dev_classify(const struct ata_taskfile *tf);
+@@ -1900,9 +1900,9 @@ extern const struct ata_port_operations
+       .sg_tablesize           = LIBATA_MAX_PRD,               \
+       .dma_boundary           = ATA_DMA_BOUNDARY
+ 
+-extern void ata_bmdma_qc_prep(struct ata_queued_cmd *qc);
++extern enum ata_completion_errors ata_bmdma_qc_prep(struct ata_queued_cmd *qc);
+ extern unsigned int ata_bmdma_qc_issue(struct ata_queued_cmd *qc);
+-extern void ata_bmdma_dumb_qc_prep(struct ata_queued_cmd *qc);
++extern enum ata_completion_errors ata_bmdma_dumb_qc_prep(struct ata_queued_cmd *qc);
+ extern unsigned int ata_bmdma_port_intr(struct ata_port *ap,
+                                     struct ata_queued_cmd *qc);
+ extern irqreturn_t ata_bmdma_interrupt(int irq, void *dev_instance);

diff --git a/queue-5.4/ata-sata_mv-avoid-trigerrable-bug_on.patch b/queue-5.4/ata-sata_mv-avoid-trigerrable-bug_on.patch
new file mode 100644 (file)
index 0000000..1d2184a
--- /dev/null
+++ b/queue-5.4/ata-sata_mv-avoid-trigerrable-bug_on.patch
@@ -0,0 +1,53 @@
+From e9f691d899188679746eeb96e6cb520459eda9b4 Mon Sep 17 00:00:00 2001
+From: Jiri Slaby <jslaby@suse.cz>
+Date: Thu, 31 Oct 2019 10:59:46 +0100
+Subject: ata: sata_mv, avoid trigerrable BUG_ON
+
+From: Jiri Slaby <jslaby@suse.cz>
+
+commit e9f691d899188679746eeb96e6cb520459eda9b4 upstream.
+
+There are several reports that the BUG_ON on unsupported command in
+mv_qc_prep can be triggered under some circumstances:
+https://bugzilla.suse.com/show_bug.cgi?id=1110252
+https://serverfault.com/questions/888897/raid-problems-after-power-outage
+https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1652185
+https://bugs.centos.org/view.php?id=14998
+
+Let sata_mv handle the failure gracefully: warn about that incl. the
+failed command number and return an AC_ERR_INVALID error. We can do that
+now thanks to the previous patch.
+
+Remove also the long-standing FIXME.
+
+[v2] use %.2x as commands are defined as hexa.
+
+Signed-off-by: Jiri Slaby <jslaby@suse.cz>
+Cc: Jens Axboe <axboe@kernel.dk>
+Cc: linux-ide@vger.kernel.org
+Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/ata/sata_mv.c |    8 +++-----
+ 1 file changed, 3 insertions(+), 5 deletions(-)
+
+--- a/drivers/ata/sata_mv.c
++++ b/drivers/ata/sata_mv.c
+@@ -2098,12 +2098,10 @@ static enum ata_completion_errors mv_qc_
+                * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none
+                * of which are defined/used by Linux.  If we get here, this
+                * driver needs work.
+-               *
+-               * FIXME: modify libata to give qc_prep a return value and
+-               * return error here.
+                */
+-              BUG_ON(tf->command);
+-              break;
++              ata_port_err(ap, "%s: unsupported command: %.2x\n", __func__,
++                              tf->command);
++              return AC_ERR_INVALID;
+       }
+       mv_crqb_pack_cmd(cw++, tf->nsect, ATA_REG_NSECT, 0);
+       mv_crqb_pack_cmd(cw++, tf->hob_lbal, ATA_REG_LBAL, 0);

diff --git a/queue-5.4/series b/queue-5.4/series
index 7313d878e967fbfd596d12af20550bf7416e2175..9b45b64f8835d1f062e89e2609387ab1fc182735 100644 (file)
--- a/queue-5.4/series
+++ b/queue-5.4/series
@@ -383,3 +383,6 @@ s390-zcrypt-fix-zcrypt_perdev_reqcnt-ioctl.patch
 kvm-arm64-assume-write-fault-on-s1ptw-permission-fault-on-instruction-fetch.patch
 dm-fix-bio-splitting-and-its-bio-completion-order-for-regular-io.patch
 kprobes-fix-compiler-warning-for-config_kprobes_on_ftrace.patch
+ata-define-ac_err_ok.patch
+ata-make-qc_prep-return-ata_completion_errors.patch
+ata-sata_mv-avoid-trigerrable-bug_on.patch