creds: drop unnecessary initialization

Coverity also thinks a leak happens here, CID #1458112.
This seems wrong, but let's add an assert, maybe that'll help.

diff --git a/src/basic/hexdecoct.c b/src/basic/hexdecoct.c
index 172ae8a9218b9644bc68ca8788cd15ccc2b63737..8c83a0e71a6befe1b6549d5ea8c1c921b40449c0 100644 (file)
--- a/src/basic/hexdecoct.c
+++ b/src/basic/hexdecoct.c
@@ -645,6 +645,7 @@ ssize_t base64mem_full(
 
         *z = 0;
         *out = r;
+        assert(z >= r); /* Let static analyzers know that the answer is non-negative. */
         return z - r;
 }
 

diff --git a/src/creds/creds.c b/src/creds/creds.c
index 50de685cd4a43fd8dd7a8e295ab1e65032c573dd..19893fb3619a1f5948b9def3892db09848b62536 100644 (file)
--- a/src/creds/creds.c
+++ b/src/creds/creds.c
@@ -193,7 +193,7 @@ static int transcode(
         switch (arg_transcode) {
 
         case TRANSCODE_BASE64: {
-                char *buf = NULL;
+                char *buf;
                 ssize_t l;
 
                 l = base64mem_full(input, input_size, 79, &buf);