]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform: arm64: huawei-gaokun-ec: fix OF node leak
authorJohan Hovold <johan@kernel.org>
Tue, 8 Jul 2025 08:53:58 +0000 (10:53 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 11 Jul 2025 15:48:39 +0000 (18:48 +0300)
Make sure to drop the OF node reference taken when creating the Gaokun
auxiliary devices when the devices are later released.

Fixes: 7636f090d02e ("platform: arm64: add Huawei Matebook E Go EC driver")
Cc: Pengyu Luo <mitltlatltl@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Pengyu Luo <mitltlatltl@gmail.com>
Link: https://lore.kernel.org/r/20250708085358.15657-1-johan@kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/arm64/huawei-gaokun-ec.c

index 7e5aa7ca24032862a7a9165b6be313afbc7adef2..7170f8eb76f7b85068347fc47bdcfaa23d9e1ef4 100644 (file)
@@ -662,6 +662,7 @@ static void gaokun_aux_release(struct device *dev)
 {
        struct auxiliary_device *adev = to_auxiliary_dev(dev);
 
+       of_node_put(dev->of_node);
        kfree(adev);
 }
 
@@ -693,6 +694,7 @@ static int gaokun_aux_init(struct device *parent, const char *name,
 
        ret = auxiliary_device_init(adev);
        if (ret) {
+               of_node_put(adev->dev.of_node);
                kfree(adev);
                return ret;
        }