Fix estimated throughput based skip-roam case

Commit 8d1e693186336f85bf5d86bd094b5c9bd6f8fd02 ('Use estimated
throughput to avoid signal based roaming decision') added a check for
the current BSS estimated throughput being significantly higher than the
selected BSS estimated throughput. However, this case for skipping a
roam used "return 1" which actually allows the roam. Fix this by
returning 0 in this case.

Signed-off-by: Jouni Malinen <j@w1.fi>

diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
index 76805e08c156e1da2723fa3358994adf24634f7f..24dbd3e2d2bfd7dfbaa238a1b2601a64b9c96aab 100644 (file)
--- a/wpa_supplicant/events.c
+++ b/wpa_supplicant/events.c
@@ -1561,7 +1561,7 @@ static int wpa_supplicant_need_to_roam(struct wpa_supplicant *wpa_s,
        if (current_bss->est_throughput > selected->est_throughput + 5000) {
                wpa_dbg(wpa_s, MSG_DEBUG,
                        "Skip roam - Current BSS has better estimated throughput");
-               return 1;
+               return 0;
        }
 
        cur_est = current_bss->est_throughput;