]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: arm_scmi: Add support to reset the debug metrics
authorLuke Parkin <luke.parkin@arm.com>
Mon, 5 Aug 2024 13:10:12 +0000 (14:10 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Fri, 9 Aug 2024 13:21:43 +0000 (14:21 +0100)
It is sometimes useful to reset all these SCMI communication debug
metrics especially when we are interested in analysing these metrics
during a particular workload or for a fixed time duration. Let us
add the capability to reset all these metrics as once so that they
can be counted during the period of interest.

Signed-off-by: Luke Parkin <luke.parkin@arm.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Tested-by: Cristian Marussi <cristian.marussi@arm.com>
Message-Id: <20240805131013.587016-6-sudeep.holla@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/driver.c

index ade32a67ab632d8f08a70674c03e47bf1e5c8df8..ca910079d7184789d0e6dda4e3f77d077678e5b2 100644 (file)
@@ -2864,6 +2864,24 @@ static const char * const dbg_counter_strs[] = {
        "err_protocol",
 };
 
+static ssize_t reset_all_on_write(struct file *filp, const char __user *buf,
+                                 size_t count, loff_t *ppos)
+{
+       struct scmi_debug_info *dbg = filp->private_data;
+
+       for (int i = 0; i < SCMI_DEBUG_COUNTERS_LAST; i++)
+               atomic_set(&dbg->counters[i], 0);
+
+       return count;
+}
+
+static const struct file_operations fops_reset_counts = {
+       .owner = THIS_MODULE,
+       .open = simple_open,
+       .llseek = no_llseek,
+       .write = reset_all_on_write,
+};
+
 static void scmi_debugfs_counters_setup(struct scmi_debug_info *dbg,
                                        struct dentry *trans)
 {
@@ -2873,8 +2891,10 @@ static void scmi_debugfs_counters_setup(struct scmi_debug_info *dbg,
        counters = debugfs_create_dir("counters", trans);
 
        for (idx = 0; idx < SCMI_DEBUG_COUNTERS_LAST; idx++)
-               debugfs_create_atomic_t(dbg_counter_strs[idx], 0400, counters,
+               debugfs_create_atomic_t(dbg_counter_strs[idx], 0600, counters,
                                        &dbg->counters[idx]);
+
+       debugfs_create_file("reset", 0200, counters, dbg, &fops_reset_counts);
 }
 
 static void scmi_debugfs_common_cleanup(void *d)