]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: fixed_phy: fix missing initialization of fixed phy link
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 19 Nov 2025 07:05:45 +0000 (08:05 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Nov 2025 02:16:59 +0000 (18:16 -0800)
Original change remove the link initialization from the passed struct
fixed_phy_status, but @status is also passed to __fixed_phy_add(),
where it is saved. Make sure that copy also has link set to 1.

Fixes: 9f07af1d2742 ("net: phy: fixed_phy: initialize the link status as up")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/dab6c10e-725e-4648-9662-39cc821723d0@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/fixed_phy.c

index 1ad77f542c1faa51252f221f7374d6cae7a984d4..1ea67119f08f96b55fc18607c2138a005a1dcbc7 100644 (file)
@@ -124,6 +124,7 @@ static int __fixed_phy_add(int phy_addr,
 
        fp->addr = phy_addr;
        fp->status = *status;
+       fp->status.link = true;
 
        list_add_tail(&fp->node, &fmb_phys);