]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: qup: Use new spi_xfer_is_dma_mapped() helper
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 31 May 2024 19:42:39 +0000 (22:42 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 10 Jun 2024 11:49:02 +0000 (12:49 +0100)
Replace a few lines of code by calling a spi_xfer_is_dma_mapped() helper.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
Link: https://lore.kernel.org/r/20240531194723.1761567-8-andriy.shevchenko@linux.intel.com
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Tested-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qup.c

index 2af63040ac6e85dbf6bb788dc327212f258fc898..06da4aa7eeb7d9565bd36b6b0ef4ed78deba19e9 100644 (file)
@@ -5,6 +5,8 @@
 
 #include <linux/clk.h>
 #include <linux/delay.h>
+#include <linux/dma-mapping.h>
+#include <linux/dmaengine.h>
 #include <linux/err.h>
 #include <linux/interconnect.h>
 #include <linux/interrupt.h>
@@ -16,8 +18,7 @@
 #include <linux/pm_opp.h>
 #include <linux/pm_runtime.h>
 #include <linux/spi/spi.h>
-#include <linux/dmaengine.h>
-#include <linux/dma-mapping.h>
+#include "internals.h"
 
 #define QUP_CONFIG                     0x0000
 #define QUP_STATE                      0x0004
@@ -709,9 +710,7 @@ static int spi_qup_io_prep(struct spi_device *spi, struct spi_transfer *xfer)
 
        if (controller->n_words <= (controller->in_fifo_sz / sizeof(u32)))
                controller->mode = QUP_IO_M_MODE_FIFO;
-       else if (spi->controller->can_dma &&
-                spi->controller->can_dma(spi->controller, spi, xfer) &&
-                spi->controller->cur_msg_mapped)
+       else if (spi_xfer_is_dma_mapped(spi->controller, spi, xfer))
                controller->mode = QUP_IO_M_MODE_BAM;
        else
                controller->mode = QUP_IO_M_MODE_BLOCK;