]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
locking/lockdep: Change 'static const' variables to enum values
authorArnd Bergmann <arnd@arndb.de>
Wed, 9 Apr 2025 12:22:58 +0000 (14:22 +0200)
committerBoqun Feng <boqun.feng@gmail.com>
Tue, 15 Jul 2025 04:57:29 +0000 (21:57 -0700)
gcc warns about 'static const' variables even in headers when building
with -Wunused-const-variables enabled:

In file included from kernel/locking/lockdep_proc.c:25:
kernel/locking/lockdep_internals.h:69:28: error: 'LOCKF_USED_IN_IRQ_READ' defined but not used [-Werror=unused-const-variable=]
   69 | static const unsigned long LOCKF_USED_IN_IRQ_READ =
      |                            ^~~~~~~~~~~~~~~~~~~~~~
kernel/locking/lockdep_internals.h:63:28: error: 'LOCKF_ENABLED_IRQ_READ' defined but not used [-Werror=unused-const-variable=]
   63 | static const unsigned long LOCKF_ENABLED_IRQ_READ =
      |                            ^~~~~~~~~~~~~~~~~~~~~~
kernel/locking/lockdep_internals.h:57:28: error: 'LOCKF_USED_IN_IRQ' defined but not used [-Werror=unused-const-variable=]
   57 | static const unsigned long LOCKF_USED_IN_IRQ =
      |                            ^~~~~~~~~~~~~~~~~
kernel/locking/lockdep_internals.h:51:28: error: 'LOCKF_ENABLED_IRQ' defined but not used [-Werror=unused-const-variable=]
   51 | static const unsigned long LOCKF_ENABLED_IRQ =
      |                            ^~~~~~~~~~~~~~~~~

This one is easy to avoid by changing the generated constant definition
into an equivalent enum.

Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250409122314.2848028-6-arnd@kernel.org
kernel/locking/lockdep_internals.h

index 82156caf77d1c0c3d1f91b84d30f4dabd8249df4..0e5e6ffe91a3fe4192713d3a02ed45cc70cb19ea 100644 (file)
@@ -47,29 +47,31 @@ enum {
        __LOCKF(USED_READ)
 };
 
+enum {
 #define LOCKDEP_STATE(__STATE) LOCKF_ENABLED_##__STATE |
-static const unsigned long LOCKF_ENABLED_IRQ =
+       LOCKF_ENABLED_IRQ =
 #include "lockdep_states.h"
-       0;
+       0,
 #undef LOCKDEP_STATE
 
 #define LOCKDEP_STATE(__STATE) LOCKF_USED_IN_##__STATE |
-static const unsigned long LOCKF_USED_IN_IRQ =
+       LOCKF_USED_IN_IRQ =
 #include "lockdep_states.h"
-       0;
+       0,
 #undef LOCKDEP_STATE
 
 #define LOCKDEP_STATE(__STATE) LOCKF_ENABLED_##__STATE##_READ |
-static const unsigned long LOCKF_ENABLED_IRQ_READ =
+       LOCKF_ENABLED_IRQ_READ =
 #include "lockdep_states.h"
-       0;
+       0,
 #undef LOCKDEP_STATE
 
 #define LOCKDEP_STATE(__STATE) LOCKF_USED_IN_##__STATE##_READ |
-static const unsigned long LOCKF_USED_IN_IRQ_READ =
+       LOCKF_USED_IN_IRQ_READ =
 #include "lockdep_states.h"
-       0;
+       0,
 #undef LOCKDEP_STATE
+};
 
 #define LOCKF_ENABLED_IRQ_ALL (LOCKF_ENABLED_IRQ | LOCKF_ENABLED_IRQ_READ)
 #define LOCKF_USED_IN_IRQ_ALL (LOCKF_USED_IN_IRQ | LOCKF_USED_IN_IRQ_READ)